Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: HustonMmmavr <huston.mavr@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] static build: fix build on ubuntu
Date: Tue, 9 Jun 2020 19:33:30 +0300	[thread overview]
Message-ID: <20200609163330.j6iqddyjwbl2ctv2@tkn_work_nb> (raw)
In-Reply-To: <20200526151747.93659-1-huston.mavr@gmail.com>

LGTM.

I didn't verify it manually, but the change itself looks reasonable and
CI pass (except flaky tests and known Mac OS X problem on Travis-CI).

Sergey, can you look into the proposed change too?

Alexander (Tikhonov), we added a CI job to verify such things within
[1]. Can you, please, look how it appears that the job didn't catch the
problem?

> Issue: https://github.com/tarantool/tarantool/issues/5024
> Branch: https://github.com/tarantool/tarantool/tree/HustonMmmavr/gh-5024-static-build-ubuntu

Please, answer with a changelog entry for future release notes. We track
user-visible behaviour changes this way: bugfixes and features. When
there is a fix for some build target or configuration, we mention it
too.

It is just free form description of changes for a user to be placed on
the [releases page][2]. We highlight with @ChangeLog 'tag' to bring a
mainterner attention.

Since it is the regression, it would be good to mention, when the
problem appears (`git describe bad_commit` output), in the future
release notes.

For future patches: add it to a cover letter or under `---` for a
signleton patchset (but do not add to a commit message).

[1]: https://github.com/tarantool/tarantool/issues/4551
[2]: https://github.com/tarantool/tarantool/releases

WBR, Alexander Turenko.

  reply	other threads:[~2020-06-09 16:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26 15:17 HustonMmmavr
2020-06-09 16:33 ` Alexander Turenko [this message]
2020-06-10  8:24   ` Mavr Huston
2020-06-10  9:20 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200609163330.j6iqddyjwbl2ctv2@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=huston.mavr@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] static build: fix build on ubuntu' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox