From: Sergey Bronnikov <sergeyb@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: alexander.turenko@tarantool.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/6] Add initial luacheck config
Date: Tue, 9 Jun 2020 19:16:05 +0300 [thread overview]
Message-ID: <20200609161605.GC67772@pony.bronevichok.ru> (raw)
In-Reply-To: <7a3dac5d-b4a6-a9b9-2f0e-076e46f6a38f@tarantool.org>
Hi,
thanks for review!
On 20:02 Sat 06 Jun , Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
>
> On 04/06/2020 10:39, sergeyb@tarantool.org wrote:
> > From: Sergey Bronnikov <sergeyb@tarantool.org>
> >
> > config includes all files with Lua source code except:
>
> Lets start sentences from capital letters.
>
> > - third_party repositories
> > - directories with diff-based tests
>
> Seems like src/* is excluded. So nothing is checked, and the
> commit message is wrong.
Agree, removed section "how-to" in a commit message.
Next commit brings target 'luacheck' and it's commit message
self-explain how to execute static analysis.
> I see, that you turn on the checks in next commits, but then the
> commit message should be changed.
>
> > How-to check:
> >
> > $ luacheck --codes --config .luacheckrc .
> >
> > Part of #4681
> >
> > Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> > Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
--
sergeyb@
next prev parent reply other threads:[~2020-06-09 16:17 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 8:39 [Tarantool-patches] [PATCH 0/6] Add static analysis of Lua code in src/ and extra/ with luacheck sergeyb
2020-06-04 8:39 ` [Tarantool-patches] [PATCH 1/6] Add initial luacheck config sergeyb
2020-06-06 18:02 ` Vladislav Shpilevoy
2020-06-09 16:16 ` Sergey Bronnikov [this message]
2020-06-04 8:39 ` [Tarantool-patches] [PATCH 2/6] build: enable 'make luacheck' target sergeyb
2020-06-04 8:39 ` [Tarantool-patches] [PATCH 3/6] gitlab-ci: enable static analysis with luacheck sergeyb
2020-06-04 8:39 ` [Tarantool-patches] [PATCH 4/6] Fix luacheck warnings in extra/dist/ sergeyb
2020-06-06 18:02 ` Vladislav Shpilevoy
2020-06-09 16:17 ` Sergey Bronnikov
2020-06-19 23:15 ` Vladislav Shpilevoy
2020-07-05 16:28 ` Vladislav Shpilevoy
2020-07-12 15:37 ` Vladislav Shpilevoy
2020-07-13 10:01 ` Sergey Bronnikov
2020-06-04 8:39 ` [Tarantool-patches] [PATCH 5/6] Fix luacheck warnings in src/lua/ sergeyb
2020-06-06 18:03 ` Vladislav Shpilevoy
2020-06-11 12:00 ` Sergey Bronnikov
2020-06-11 19:52 ` Vladislav Shpilevoy
2020-06-18 9:32 ` Sergey Bronnikov
2020-06-18 9:35 ` Sergey Bronnikov
2020-06-11 17:22 ` Igor Munkin
2020-07-05 16:28 ` Vladislav Shpilevoy
2020-07-10 16:55 ` Sergey Bronnikov
2020-07-12 15:37 ` Vladislav Shpilevoy
2020-07-13 9:51 ` Sergey Bronnikov
2020-07-13 22:59 ` Vladislav Shpilevoy
2020-06-04 8:39 ` [Tarantool-patches] [PATCH 6/6] Fix luacheck warnings in src/box/lua/ sergeyb
2020-06-06 18:03 ` Vladislav Shpilevoy
2020-06-11 12:01 ` Sergey Bronnikov
2020-06-18 9:37 ` Sergey Bronnikov
2020-06-19 23:15 ` Vladislav Shpilevoy
2020-07-01 14:02 ` Sergey Bronnikov
2020-07-13 22:59 ` Vladislav Shpilevoy
2020-07-14 10:54 ` Sergey Bronnikov
2020-07-14 11:24 ` Sergey Bronnikov
2020-06-04 8:43 ` [Tarantool-patches] [PATCH 0/6] Add static analysis of Lua code in src/ and extra/ with luacheck Sergey Bronnikov
2020-06-19 23:15 ` Vladislav Shpilevoy
2020-07-13 9:53 ` Sergey Bronnikov
2020-06-04 9:04 ` Igor Munkin
2020-06-04 11:17 ` Sergey Bronnikov
2020-07-14 22:49 ` Vladislav Shpilevoy
2020-07-15 9:51 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200609161605.GC67772@pony.bronevichok.ru \
--to=sergeyb@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/6] Add initial luacheck config' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox