From: Kirill Yukhin <kyukhin@tarantool.org>
To: Dmitry Khominich <khdmitryi@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] error: use int64_t as reference counter
Date: Tue, 9 Jun 2020 14:49:10 +0300 [thread overview]
Message-ID: <20200609114910.7idlcug3eqeybsgo@tarantool.org> (raw)
In-Reply-To: <20200608153042.55274-1-khdmitryi@gmail.com>
Hello,
On 08 июн 18:30, Dmitry Khominich wrote:
> Before it was unsafe to use error.prev, box.error.last(), or any error
> method that increments error reference counter. Any of them could throw a
> Lua error in case of INT32_MAX overflow.
>
> This patch uses int64_t as error reference counter making it impossible
> to get counter overflow.
>
> Closes #4902
> ---
> Branch: https://github.com/dmitryikh/tarantool/tree/error_ref_to_int64
> Issue: https://github.com/tarantool/tarantool/issues/4902
I've checked your patch into 2.4 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-06-09 11:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 15:30 Dmitry Khominich
2020-06-09 11:49 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200609114910.7idlcug3eqeybsgo@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=khdmitryi@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] error: use int64_t as reference counter' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox