From: Sergey Bronnikov <sergeyb@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1] Divide test box/net.box
Date: Mon, 8 Jun 2020 23:10:58 +0300 [thread overview]
Message-ID: <20200608201058.GE53062@pony.bronevichok.ru> (raw)
In-Reply-To: <20200604155057.GA27465@hpalx>
Hi, Sasha!
thanks for update!
Please replace "Close #4880" in a commit message to "Closes #4880",
as recommended in Developer guidelines [1].
LGTM
1. https://www.tarantool.io/en/doc/2.3/dev_guide/developer_guidelines/
On 18:50 Thu 04 Jun , Alexander V. Tikhonov wrote:
> Hi Sergey, thanks a lot for the review, please check my answers below.
prev parent reply other threads:[~2020-06-08 20:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 6:38 Alexander V. Tikhonov
2020-04-02 15:44 ` Sergey Bronnikov
2020-05-15 17:04 ` Alexander V. Tikhonov
2020-05-18 10:00 ` Sergey Bronnikov
2020-06-01 9:24 ` Alexander V. Tikhonov
2020-06-04 10:33 ` Sergey Bronnikov
2020-06-04 15:50 ` Alexander V. Tikhonov
2020-06-08 20:10 ` Sergey Bronnikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608201058.GE53062@pony.bronevichok.ru \
--to=sergeyb@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] Divide test box/net.box' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox