From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B1282469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  8 Jun 2020 23:12:06 +0300 (MSK)
Date: Mon, 8 Jun 2020 23:10:58 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200608201058.GE53062@pony.bronevichok.ru>
References: <caffa40a3ab11d147cea5ebd64048f225dd26e29.1585809264.git.avtikhon@tarantool.org>
 <20200402154444.GA8132@pony.bronevichok.ru>
 <20200515170409.GA10228@hpalx>
 <20200518100058.GC20053@pony.bronevichok.ru>
 <20200601092449.GA5590@hpalx>
 <20200604103311.GA19065@pony.bronevichok.ru>
 <20200604155057.GA27465@hpalx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200604155057.GA27465@hpalx>
Subject: Re: [Tarantool-patches] [PATCH v1] Divide test box/net.box
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi, Sasha!

thanks for update!
Please replace "Close #4880" in a commit message to "Closes #4880",
as recommended in Developer guidelines [1].

LGTM

1. https://www.tarantool.io/en/doc/2.3/dev_guide/developer_guidelines/

On 18:50 Thu 04 Jun , Alexander V. Tikhonov wrote:
> Hi Sergey, thanks a lot for the review, please check my answers below.