Re: [Tarantool-patches] [PATCH 1/2] test: update unit test lib to produce TAP-compliant output

[Sergey Bronnikov <sergeyb@tarantool.org>]

Hi, Vladislav

thanks for spending time on review of my patches!

On 00:52 Thu 04 Jun , Vladislav Shpilevoy wrote:
> Thanks for the patch!
> 
> > diff --git a/test/unit/unit.h b/test/unit/unit.h
> > index 43c301b28..27879ea98 100644
> > --- a/test/unit/unit.h
> > +++ b/test/unit/unit.h
> > @@ -129,6 +126,16 @@ int check_plan(void);
> >  	}						\
> >  }
> >  
> > +#define header() do {				\
> > +	_space(stdout);				\
> > +	printf("# *** %s ***\n", __func__);	\
> > +} while(0)
> > +
> > +#define footer() do {					\
> > +	_space(stdout);					\
> > +	printf("# *** %s: done ***\n", __func__);	\
> 
> Since alignment is used, lets use it correctly. And align all
> the slashes in the same way.

Fixed.

> I mean footer and header slashes. Slightly screwed tabs inside
> footer and inside header macros are git diff artifacts, no problem
> here.
> 
> > +} while(0)
> > +
> >  #if defined(__cplusplus)
> >  }
> >  #endif /* defined(__cplusplus) */

-- 
sergeyb@