Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov <sergeyb@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2] Add option to update file with reference output
Date: Mon, 8 Jun 2020 18:31:11 +0300	[thread overview]
Message-ID: <20200608153111.GA53062@pony.bronevichok.ru> (raw)
In-Reply-To: <20200608091958.twb4dmv4zeaqtlfe@tkn_work_nb>

Hi,

Alexander, I send a new version of patches with fixes after review.

On 12:19 Mon 08 Jun , Alexander Turenko wrote:
> Sergey, please squash fixup commits before sending a next version of a
> patchset to review.
> 
> Please, put flake8 configuration update first: so each commit will pass
> CI.

put it first on updated patchset

> The 'new' status disappears in the new patchset version. Can you look at
> this again? It looks as unintentional change.

Yeah, my bad. Fixed it.

> > -            elif not self.is_crash_reported and not self.is_equal_result:
> > +            elif (not self.is_crash_reported and not self.is_equal_result):
> 
> Please, avoid unneeded diffs.

reverted change

> WBR, Alexander Turenko.

-- 
sergeyb@

      reply	other threads:[~2020-06-08 15:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 10:25 sergeyb
2020-05-20  8:03 ` Alexander V. Tikhonov
2020-05-20  8:23   ` Sergey Bronnikov
2020-06-03 17:27 ` Alexander Turenko
2020-06-04 13:07   ` Sergey Bronnikov
2020-06-08  9:19     ` Alexander Turenko
2020-06-08 15:31       ` Sergey Bronnikov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200608153111.GA53062@pony.bronevichok.ru \
    --to=sergeyb@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=o.piskunov@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2] Add option to update file with reference output' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox