Re: [Tarantool-patches] [PATCH v2 2/3] gitlab-ci: add out-of-source build

[Alexander Turenko <alexander.turenko@tarantool.org>]

While we discussing curl and so, there is clear fix re bootstrap.h. I'll
not mind if you'll send it within a separate patch.

On Wed, May 13, 2020 at 10:40:00AM +0300, Alexander V. Tikhonov wrote:
> Hi Alexander, thanks a lot for the review, please check my comments below.
> 
> On Sat, Apr 25, 2020 at 10:17:30AM +0300, Alexander Turenko wrote:
> > > index 5f8b15a63..753b7293a 100644
> > > --- a/cmake/BuildLibCURL.cmake
> > > +++ b/cmake/BuildLibCURL.cmake
> > > @@ -56,10 +56,10 @@ macro(curl_build)
> > >          DOWNLOAD_DIR ${LIBCURL_BINARY_DIR}
> > >          TMP_DIR ${LIBCURL_BINARY_DIR}/tmp
> > >          STAMP_DIR ${LIBCURL_BINARY_DIR}/stamp
> > > -        BINARY_DIR ${LIBCURL_BINARY_DIR}
> > > +        BINARY_DIR ${LIBCURL_BINARY_DIR}/curl
> > 
> > Don't get what is the problem you try to solve here.
> > 
> 
> The path to curl binaries is set here, which later used
> for configuring/building/installing and no need to write
> it there each time.

I'll try to ask it in other words. What is wrong with
LIBCURL_BINARY_DIR, which is ${PROJECT_BINARY_DIR}/build/curl/work now?
Okay, if something wrong, then shouldn't we set it to
${PROJECT_BINARY_DIR}/build/curl/work/curl right at initialization
(however I don't see a reason)?

Is not the reason https://github.com/curl/curl/pull/5213 ? Can we avoid
this change if we'll update the curl submodule?

WBR, Alexander TUrenko.