From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] decimal: fix build with GCC 10
Date: Mon, 8 Jun 2020 14:22:13 +0300 [thread overview]
Message-ID: <20200608112213.hf4fjwwikct74qab@tkn_work_nb> (raw)
In-Reply-To: <20200605140125.25329-1-sergepetrenko@tarantool.org>
The patch itself is okay.
On Fri, Jun 05, 2020 at 05:01:25PM +0300, Serge Petrenko wrote:
> GCC 10 produces the following error:
> cc1: warning: function may return address of local variable [-Wreturn-local-addr]
>
> Fix it.
It would be good to mention whether it is a real problem or
false-positive. (The patch is already pushed, so this comment is just
for information.)
As I see, we actually return a data on the stack before the patch, so it
worth to mention the bugfix in the release notes. Kirill, can you add
this?
@ChangeLog
- Fix use-after-scope when converting a decimal number to int64_t or
uint64_t that may lead to undefined behaviour in tuple comparators and
so in behaviour of space indices (part of gh-4966).
(Serge, correct me if I'm wrong here.)
BTW, are those hints pesisted for vinyl? Can we get wrong results even
after upgrade?
WBR, Alexander Turenko.
next prev parent reply other threads:[~2020-06-08 11:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 14:01 Serge Petrenko
2020-06-06 5:31 ` Alexander V. Tikhonov
2020-06-08 10:23 ` Kirill Yukhin
2020-06-08 11:22 ` Alexander Turenko [this message]
2020-06-08 11:30 ` Serge Petrenko
2020-06-08 11:36 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608112213.hf4fjwwikct74qab@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] decimal: fix build with GCC 10' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox