From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Oleg Babin <olegrok@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v9 0/2] lua/log: add an ability to setup logger without box.cfg{}
Date: Fri, 5 Jun 2020 22:21:24 +0300 [thread overview]
Message-ID: <20200605192124.GA2094@grain> (raw)
In-Reply-To: <c7402855-f5a3-b7e4-ba66-79a2e39ce39c@tarantool.org>
On Fri, Jun 05, 2020 at 10:14:51PM +0300, Oleg Babin wrote:
> Hi! Thanks for your patchset. I think this series should be pushed - LGTM.
> However I have several comments:
> - Don't forget to file an issue to rework approarch to module
> configuratoin and remove dead code (I suppose that functions
> private.cfg_set_log_level and private.cfg_set_log_format will be unused
> after that);
> - It would be nice to add tests from your previous series where you test
> possibility to pass string as log level.
Yes. I've a plan to address all this. Next week. Thanks!
next prev parent reply other threads:[~2020-06-05 19:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 18:55 Cyrill Gorcunov
2020-06-05 18:55 ` [Tarantool-patches] [PATCH v9 1/2] lua/log: add ability to configure logging early Cyrill Gorcunov
2020-06-05 18:55 ` [Tarantool-patches] [PATCH v9 2/2] test: app-tap/logger -- test new modes Cyrill Gorcunov
2020-06-05 19:14 ` [Tarantool-patches] [PATCH v9 0/2] lua/log: add an ability to setup logger without box.cfg{} Oleg Babin
2020-06-05 19:21 ` Cyrill Gorcunov [this message]
2020-06-08 9:36 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605192124.GA2094@grain \
--to=gorcunov@gmail.com \
--cc=olegrok@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v9 0/2] lua/log: add an ability to setup logger without box.cfg{}' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox