From: Nikita Pettik <korablev@tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>,
tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org,
alyapunov@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] vinyl: rotate mem during index build on demand
Date: Fri, 5 Jun 2020 11:18:15 +0000 [thread overview]
Message-ID: <20200605111815.GA26017@tarantool.org> (raw)
In-Reply-To: <20200604225215.GB146885@atlas>
On 05 Jun 01:52, Konstantin Osipov wrote:
> * Nikita Pettik <korablev@tarantool.org> [20/06/04 20:49]:
> > So to get rid of generations mismatch, let's rotate in-memory level
> > after yield on demand.
>
> Could you please also elaborate why generation mismatch is bad
> here? What does it lead to specifically?
Because right after yield, vy_stmt is allocated using ls region
(in vy_build_insert_stmt()) and inserted into mem. Ls region does
not tolerate non-decreasing ids: otherwise region gc may truncate
data which is still accessible.
>
> --
> Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-06-05 11:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 17:49 Nikita Pettik
2020-06-04 20:23 ` Konstantin Osipov
2020-06-04 22:32 ` Nikita Pettik
2020-06-04 22:52 ` Konstantin Osipov
2020-06-05 11:18 ` Nikita Pettik [this message]
2020-06-05 11:33 ` Konstantin Osipov
2020-06-06 8:38 ` Aleksandr Lyapunov
2020-06-07 15:51 ` Vladislav Shpilevoy
2020-06-09 22:34 ` Nikita Pettik
2020-06-15 13:54 ` Nikita Pettik
2020-06-23 22:43 ` Vladislav Shpilevoy
2020-06-23 23:11 ` Nikita Pettik
2020-07-22 22:54 ` Vladislav Shpilevoy
2020-06-10 15:27 ` Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605111815.GA26017@tarantool.org \
--to=korablev@tarantool.org \
--cc=alyapunov@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] vinyl: rotate mem during index build on demand' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox