Re: [Tarantool-patches] [PATCH 0/6] Add static analysis of Lua code in src/ and extra/ with luacheck

[Igor Munkin <imun@tarantool.org>]

Sergey,

Thanks for the series! Please provide a ChangeLog entry.

Since I was involved in preparing this series, my review is not
sufficient anymore.

Vlad, Sasha, could you please take look on the patchset? I guess
everything we discussed[1] is fixed now.

On 04.06.20, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> Sergey Bronnikov (6):
>   Add initial luacheck config
>   build: enable 'make luacheck' target
>   gitlab-ci: enable static analysis with luacheck
>   Fix luacheck warnings in extra/dist/
>   Fix luacheck warnings in src/lua/
>   Fix luacheck warnings in src/box/lua/
> 
>  .gitlab-ci.yml                  | 11 +++++++
>  .luacheckrc                     | 55 +++++++++++++++++++++++++++++++++
>  .travis.mk                      | 23 +++++++++++++-
>  CMakeLists.txt                  | 11 +++++++
>  extra/dist/tarantoolctl.in      | 25 +++++----------
>  src/box/lua/console.lua         | 10 +++---
>  src/box/lua/feedback_daemon.lua |  2 +-
>  src/box/lua/key_def.lua         |  2 +-
>  src/box/lua/load_cfg.lua        | 11 +++----
>  src/box/lua/net_box.lua         | 52 ++++++++++++-------------------
>  src/box/lua/schema.lua          | 44 +++++++++++++-------------
>  src/box/lua/tuple.lua           |  8 ++---
>  src/box/lua/upgrade.lua         | 19 ++++++------
>  src/lua/argparse.lua            |  3 +-
>  src/lua/buffer.lua              |  4 +--
>  src/lua/clock.lua               |  2 +-
>  src/lua/crypto.lua              |  4 +--
>  src/lua/csv.lua                 |  5 ++-
>  src/lua/digest.lua              |  2 +-
>  src/lua/env.lua                 |  2 +-
>  src/lua/fiber.lua               |  4 +--
>  src/lua/fio.lua                 | 30 +++++++++---------
>  src/lua/help.lua                |  7 ++---
>  src/lua/httpc.lua               |  3 --
>  src/lua/init.lua                |  4 +--
>  src/lua/msgpackffi.lua          | 22 ++++++-------
>  src/lua/socket.lua              | 16 +++++-----
>  src/lua/string.lua              |  1 -
>  src/lua/swim.lua                |  2 +-
>  src/lua/tap.lua                 |  4 ---
>  src/lua/trigger.lua             |  3 --
>  31 files changed, 220 insertions(+), 171 deletions(-)
>  create mode 100644 .luacheckrc
> 
> -- 
> 2.23.0

[1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-June/017370.html

-- 
Best regards,
IM