From: Igor Munkin <imun@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/3] box: always wait box loading in box.execute()
Date: Thu, 4 Jun 2020 02:12:59 +0300 [thread overview]
Message-ID: <20200603231259.GH5745@tarantool.org> (raw)
In-Reply-To: <3c0d131898ba3b78c2f36fa82873b78dbf707df6.1589321083.git.alexander.turenko@tarantool.org>
Sasha,
Thanks for the patch! It LGTM, but is "blocked" since it strongly
depends on the previous one.
On 13.05.20, Alexander Turenko wrote:
> <box_load_and_execute> checks whether box is configured with appropriate
> locking and configures it when necessary. However it is not so for
> <lbox_execute>. We should replace the former with the latter only when
> box is fully loaded.
>
> Follow-up #4231
> ---
> src/box/lua/load_cfg.lua | 20 ++++++++++++---
> .../gh-4231-box-execute-locking.test.lua | 25 ++++++++++++++++++-
> test/box-tap/suite.cfg | 6 +++++
> test/box-tap/suite.ini | 1 +
> 4 files changed, 48 insertions(+), 4 deletions(-)
> create mode 100644 test/box-tap/suite.cfg
>
<snipped>
> --
> 2.25.0
>
--
Best regards,
IM
next prev parent reply other threads:[~2020-06-03 23:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 22:18 [Tarantool-patches] [PATCH 0/3] box.execute() and box.cfg() idempotence and locking Alexander Turenko
2020-05-12 22:18 ` [Tarantool-patches] [PATCH 1/3] box: check whether box is loaded in box.execute() Alexander Turenko
2020-05-22 7:31 ` lvasiliev
2020-06-03 21:58 ` Igor Munkin
2020-06-08 18:58 ` Alexander Turenko
2020-06-11 17:43 ` Igor Munkin
2020-05-12 22:18 ` [Tarantool-patches] [PATCH 2/3] box: always wait box loading " Alexander Turenko
2020-05-22 11:08 ` lvasiliev
2020-06-03 23:12 ` Igor Munkin [this message]
2020-05-12 22:18 ` [Tarantool-patches] [PATCH 3/3] box: always reconfigure box at non-first box.cfg() Alexander Turenko
2020-05-22 7:02 ` lvasiliev
2020-06-03 22:41 ` Igor Munkin
2020-06-03 23:22 ` Igor Munkin
2020-06-08 18:59 ` Alexander Turenko
2020-06-17 22:26 ` Vladislav Shpilevoy
2020-06-18 8:41 ` Alexander Turenko
2020-06-18 22:23 ` Vladislav Shpilevoy
2020-05-22 7:06 ` [Tarantool-patches] [PATCH 0/3] box.execute() and box.cfg() idempotence and locking lvasiliev
2020-06-08 18:59 ` Alexander Turenko
2020-06-17 22:30 ` Vladislav Shpilevoy
2020-06-22 10:11 ` Kirill Yukhin
2020-06-23 23:55 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200603231259.GH5745@tarantool.org \
--to=imun@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/3] box: always wait box loading in box.execute()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox