Re: [Tarantool-patches] [PATCH v1] Set full testing for all branches

[Alexander Turenko <alexander.turenko@tarantool.org>]

I have no more objections.

If everything works as expected and we're ready to such amount of jobs,
the change will allow to catch some problems before a patch will land
into master.

BTW, please add 'gitlab-ci' prefix.

> > >  .pack_only_template: &pack_only_definition
> > >    only:
> > >      - schedules
> > >      - external_pull_requests
> > >      - merge_requests
> > > -    - /^.*-full-ci$/
> > > +    - branches
> > > +    - tags
> > 
> > First, there is not reason to list 'schedules', 'external_pull_requests'
> > and so if you want to just run it everywhere.
> > 
> 
> Actually I just wanted to make it more visible for the users, but anyway
> if it not really needed I'll change it to "except: master".
> 
> > Second, we should not run both 'just packaging' and 'packaging and
> > deployment' jobs on master. I would make ''pack_only_template' be just
> > 'except: master'. Yep, it is not perfect: 'schedules',
> > 'external_pull_requests' will don't run neither 'pack', nor 'deploy'.
> > But this change is simple and downsides are acceptable.
> > 
> 
> Right, it is the same as previous my comment.

I would mention the known downside somewhere, preferably just in this
config.