From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua
Date: Wed, 3 Jun 2020 14:37:49 +0300 [thread overview]
Message-ID: <20200603113749.GA7229@hpalx> (raw)
In-Reply-To: <20200601104756.7kxdl5kmlzn3gonm@tkn_work_nb>
Hi Alexander, thanks for the review, I've changed it as you suggested.
On Mon, Jun 01, 2020 at 01:47:56PM +0300, Alexander Turenko wrote:
> On Sun, May 31, 2020 at 08:12:42AM +0300, Alexander V. Tikhonov wrote:
> > During investigation of the issues found that error message had
> > not user friendly format:
> > local pwgr_errstr = "get%s failed [errno %d]: %s"
> > produced:
> > [001] LuajitError: builtin/pwd.lua:101: getgetgrall failed [errno 2]: No such file or directory
> > while it had to be:
> > [001] LuajitError: builtin/pwd.lua:101: get getgrall failed [errno 2]: No such file or directory
> > Fixed the error message.
>
> My bad, looks as regression from
> 6c5d3f060459c943bbba8394e7f1f91f79efb5a6 ('lua: pwd: split data fetch
> from deserialization').
>
> LGTM, but, please, make it just 'getgrall failed [errno 2]: No such file
> or directory', without leading 'get'.
>
> WBR, Alexander Turenko.
next prev parent reply other threads:[~2020-06-03 11:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 5:12 Alexander V. Tikhonov
2020-06-01 10:47 ` Alexander Turenko
2020-06-03 11:37 ` Alexander V. Tikhonov [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-31 5:09 Alexander V. Tikhonov
2020-06-01 8:57 ` Sergey Bronnikov
2020-06-03 10:13 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200603113749.GA7229@hpalx \
--to=avtikhon@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox