From: Sergey Ostanevich <sergos@tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2] lua: remove excess Lua call from table encoding
Date: Tue, 2 Jun 2020 19:57:14 +0300 [thread overview]
Message-ID: <20200602165714.GC50@tarantool.org> (raw)
In-Reply-To: <20200602150104.GA14098@root>
Hi!
Thanks for the patch!
Still I would like to see some tests - perhaps with errinj to emulate
OOM or some other case that trigger the 'excess protected frame' need.
So that after your changes it still passes.
Regards,
Sergos
On 02 июн 18:01, Sergey Kaplun wrote:
> On 02.06.20, Igor Munkin wrote:
> > Sergey,
> >
> > Nice. Almost forgot: please also provide a ChangeLog entry.
>
> @Changelog:
> * Refactor Lua table encoding: removed excess Lua function object and
> protected Lua frame creation to improve `msgpack.encode()` performance.
>
> >
> > On 02.06.20, Sergey Kaplun wrote:
> > > Hi! Thanks for the review!
> > >
> >
> > <snipped>
> >
> > >
> > > --
> > > Best regards,
> > > Sergey Kaplun
> >
> > --
> > Best regards,
> > IM
>
> --
> Best regards,
> Sergey Kaplun
next prev parent reply other threads:[~2020-06-02 16:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 12:19 Sergey Kaplun
2020-06-02 13:51 ` Igor Munkin
2020-06-02 14:16 ` Sergey Kaplun
2020-06-02 14:13 ` Igor Munkin
2020-06-02 15:01 ` Sergey Kaplun
2020-06-02 16:57 ` Sergey Ostanevich [this message]
2020-06-05 7:14 ` Sergey Kaplun
2020-06-08 16:35 ` Sergey Ostanevich
2020-06-09 10:29 ` Sergey Kaplun
2020-06-02 21:28 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602165714.GC50@tarantool.org \
--to=sergos@tarantool.org \
--cc=skaplun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2] lua: remove excess Lua call from table encoding' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox