From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Oleg Babin <olegrok@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v7 10/11] log/lua: allow to specify logging level as a string
Date: Tue, 2 Jun 2020 11:12:41 +0300 [thread overview]
Message-ID: <20200602081241.GT215590@grain> (raw)
In-Reply-To: <220cea35-47f1-6a1e-5f33-94553ec5302a@tarantool.org>
On Tue, Jun 02, 2020 at 11:05:57AM +0300, Oleg Babin wrote:
> Also. I've found that it's not allowed to set log level as string via box
> API:
>
> ```
>
> tarantool> box.cfg{log_level = 'info'}
> ---
> - error: 'Incorrect value for option ''log_level'': should be of type
> number'
> ...
>
> ```
>
> But it could be easily fixed here: https://github.com/tarantool/tarantool/blob/master/src/box/lua/load_cfg.lua#L129
Yeah, I left it on intent. Didn't want to change box.cfg api.
Currently the keywords are parsed in log module solely so I'll
have to provide some way to make similar inside load_cfg code,
and I tried to escape it.
You know, the base idea is to configure logging via log module
solely and maybe deprecate it from box.cfg.
Anyway even if I fix it I'll do it on top of the series.
next prev parent reply other threads:[~2020-06-02 8:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 22:24 [Tarantool-patches] [PATCH v7 00/11] lua/log: add an ability to setup logger without box.cfg{} Cyrill Gorcunov
2020-06-01 22:24 ` [Tarantool-patches] [PATCH v7 01/11] core/say: do not reconfig early set up logger Cyrill Gorcunov
2020-06-01 22:24 ` [Tarantool-patches] [PATCH v7 02/11] core/say: use say_logger_initialized in say_logger_free Cyrill Gorcunov
2020-06-02 7:51 ` Oleg Babin
2020-06-01 22:24 ` [Tarantool-patches] [PATCH v7 03/11] lua/log: declare say_logger_init and say_logger_initialized Cyrill Gorcunov
2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 04/11] lua/log: put string constants to map Cyrill Gorcunov
2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 05/11] lua/log: do not allow to set json for boot logger Cyrill Gorcunov
2020-06-02 7:51 ` Oleg Babin
2020-06-02 8:17 ` Cyrill Gorcunov
2020-06-03 9:44 ` Kirill Yukhin
2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 06/11] lua/log: declare log as separate variable Cyrill Gorcunov
2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 07/11] lua/log: use log module settings inside box.cfg Cyrill Gorcunov
2020-06-02 7:51 ` Oleg Babin
2020-06-02 8:15 ` Cyrill Gorcunov
2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 08/11] lua/log: allow to configure logging without a box Cyrill Gorcunov
2020-06-02 7:51 ` Oleg Babin
2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 09/11] test: use direct log module Cyrill Gorcunov
2020-06-02 7:52 ` Oleg Babin
2020-06-02 8:13 ` Cyrill Gorcunov
2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 10/11] log/lua: allow to specify logging level as a string Cyrill Gorcunov
2020-06-02 7:52 ` Oleg Babin
2020-06-02 8:05 ` Oleg Babin
2020-06-02 8:12 ` Cyrill Gorcunov [this message]
2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 11/11] lua/log: use log_cfg instead of ffi's instances Cyrill Gorcunov
2020-06-02 7:52 ` Oleg Babin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602081241.GT215590@grain \
--to=gorcunov@gmail.com \
--cc=olegrok@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v7 10/11] log/lua: allow to specify logging level as a string' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox