From: Cyrill Gorcunov <gorcunov@gmail.com> To: tml <tarantool-patches@dev.tarantool.org> Subject: [Tarantool-patches] [PATCH v7 09/11] test: use direct log module Date: Tue, 2 Jun 2020 01:25:05 +0300 [thread overview] Message-ID: <20200601222507.560415-10-gorcunov@gmail.com> (raw) In-Reply-To: <20200601222507.560415-1-gorcunov@gmail.com> To test if we can setup logging module before the box.cfg{}. Part-of #689 Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- test/app-tap/logger.test.lua | 56 ++++++++++++++++++++++++++++++++++-- 1 file changed, 53 insertions(+), 3 deletions(-) diff --git a/test/app-tap/logger.test.lua b/test/app-tap/logger.test.lua index 676c860d3..c6f207908 100755 --- a/test/app-tap/logger.test.lua +++ b/test/app-tap/logger.test.lua @@ -1,7 +1,7 @@ #!/usr/bin/env tarantool local test = require('tap').test('log') -test:plan(25) +test:plan(34) -- gh-3946: Assertion failure when using log_format() before box.cfg() local log = require('log') @@ -10,16 +10,66 @@ _,err = pcall(log, {log_format = 'json'}) test:ok(err ~= nil) -- --- Check that Tarantool creates ADMIN session for #! script +-- gh-689: Operate with logger via log module without calling box.cfg{} -- +local json = require('json') local filename = "1.log" + +-- Test json output +log.cfg({log=filename, format='json', level=5}) +local m = "info message" + +local file = io.open(filename) +while file:read() do +end + +log.info(m) +local line = file:read() +local message = json.decode(line) +file:close() + +test:is(type(message), 'table', "(log) json valid in log.info") +test:is(message.level, "INFO", "(log) check type info") +test:is(message.message, m, "(log) check message content") + +-- Test runtime change to plain format +log.log_format('plain') +local file = io.open(filename) +while file:read() do +end +log.info(m) +local line = file:read() +file:close() +test:is(line:sub(-m:len()), m, m) + +-- Test wrong arguments +_, err = pcall(log.cfg, {format = 'unknown'}) +test:ok(err ~= nil) + +-- Test that changes in log module are propagated +-- back to the box module correctly +box.cfg{ + log=filename, + log_format='json', + log_level=6, + memtx_memory=107374182, +} +test:is(box.cfg.log_format, 'json', 'box in json format') +test:is(box.cfg.log_level, 6, 'box level 6') +log.cfg({format='plain', level=5}) +test:is(box.cfg.log_format, 'plain', 'box sees plain format') +test:is(box.cfg.log_level, 5, 'box sees level change') + +-- +-- Check that Tarantool creates ADMIN session for #! script +-- local message = "Hello, World!" box.cfg{ log=filename, + log_format='plain', memtx_memory=107374182, } local fio = require('fio') -local json = require('json') local fiber = require('fiber') local file = io.open(filename) while file:read() do -- 2.26.2
next prev parent reply other threads:[~2020-06-01 22:26 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-01 22:24 [Tarantool-patches] [PATCH v7 00/11] lua/log: add an ability to setup logger without box.cfg{} Cyrill Gorcunov 2020-06-01 22:24 ` [Tarantool-patches] [PATCH v7 01/11] core/say: do not reconfig early set up logger Cyrill Gorcunov 2020-06-01 22:24 ` [Tarantool-patches] [PATCH v7 02/11] core/say: use say_logger_initialized in say_logger_free Cyrill Gorcunov 2020-06-02 7:51 ` Oleg Babin 2020-06-01 22:24 ` [Tarantool-patches] [PATCH v7 03/11] lua/log: declare say_logger_init and say_logger_initialized Cyrill Gorcunov 2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 04/11] lua/log: put string constants to map Cyrill Gorcunov 2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 05/11] lua/log: do not allow to set json for boot logger Cyrill Gorcunov 2020-06-02 7:51 ` Oleg Babin 2020-06-02 8:17 ` Cyrill Gorcunov 2020-06-03 9:44 ` Kirill Yukhin 2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 06/11] lua/log: declare log as separate variable Cyrill Gorcunov 2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 07/11] lua/log: use log module settings inside box.cfg Cyrill Gorcunov 2020-06-02 7:51 ` Oleg Babin 2020-06-02 8:15 ` Cyrill Gorcunov 2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 08/11] lua/log: allow to configure logging without a box Cyrill Gorcunov 2020-06-02 7:51 ` Oleg Babin 2020-06-01 22:25 ` Cyrill Gorcunov [this message] 2020-06-02 7:52 ` [Tarantool-patches] [PATCH v7 09/11] test: use direct log module Oleg Babin 2020-06-02 8:13 ` Cyrill Gorcunov 2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 10/11] log/lua: allow to specify logging level as a string Cyrill Gorcunov 2020-06-02 7:52 ` Oleg Babin 2020-06-02 8:05 ` Oleg Babin 2020-06-02 8:12 ` Cyrill Gorcunov 2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 11/11] lua/log: use log_cfg instead of ffi's instances Cyrill Gorcunov 2020-06-02 7:52 ` Oleg Babin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200601222507.560415-10-gorcunov@gmail.com \ --to=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v7 09/11] test: use direct log module' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox