From: Cyrill Gorcunov <gorcunov@gmail.com>
To: tml <tarantool-patches@dev.tarantool.org>
Subject: [Tarantool-patches] [PATCH v7 00/11] lua/log: add an ability to setup logger without box.cfg{}
Date: Tue, 2 Jun 2020 01:24:56 +0300 [thread overview]
Message-ID: <20200601222507.560415-1-gorcunov@gmail.com> (raw)
In the series we add an ability to configure logger early
without calling box.cfg{}. The syntax is the same as
in box.cfg{} call.
There was an idea to implement something similar via triggers but
I think this will require a way more efforts and code redesign,
so at first lets stick to simplier solution.
v2 by Oleg:
- hide box_api symbols from users
- initialize logger via log.cfg() call to look similar to box.cfg
v3 by Oleg:
- add parametesr verification
- allow to reconfig via log.cfg() call
v4 by Oleg:
- lua style fixes
- extent test (I didn't find a way to test wrong params verification
inside tap test, so I did it manually. Still we might extent the
test on top of the series).
v5..v6:
- left for internal use
v7 by Oleg and Leonid:
- add bidirectional sync between log and box settings
- symbolic names for levels
- test extension
- reduce ffi usage
branch gorcunov/gh-689-logger-7
issue https://github.com/tarantool/tarantool/issues/689
Cyrill Gorcunov (11):
core/say: do not reconfig early set up logger
core/say: use say_logger_initialized in say_logger_free
lua/log: declare say_logger_init and say_logger_initialized
lua/log: put string constants to map
lua/log: do not allow to set json for boot logger
lua/log: declare log as separate variable
lua/log: use log module settings inside box.cfg
lua/log: allow to configure logging without a box
test: use direct log module
log/lua: allow to specify logging level as a string
lua/log: use log_cfg instead of ffi's instances
src/box/lua/load_cfg.lua | 26 +++-
src/lib/core/say.c | 15 +-
src/lib/core/say.h | 4 +
src/lua/log.lua | 272 ++++++++++++++++++++++++++++++++---
test/app-tap/logger.test.lua | 86 ++++++++++-
5 files changed, 370 insertions(+), 33 deletions(-)
--
2.26.2
next reply other threads:[~2020-06-01 22:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 22:24 Cyrill Gorcunov [this message]
2020-06-01 22:24 ` [Tarantool-patches] [PATCH v7 01/11] core/say: do not reconfig early set up logger Cyrill Gorcunov
2020-06-01 22:24 ` [Tarantool-patches] [PATCH v7 02/11] core/say: use say_logger_initialized in say_logger_free Cyrill Gorcunov
2020-06-02 7:51 ` Oleg Babin
2020-06-01 22:24 ` [Tarantool-patches] [PATCH v7 03/11] lua/log: declare say_logger_init and say_logger_initialized Cyrill Gorcunov
2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 04/11] lua/log: put string constants to map Cyrill Gorcunov
2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 05/11] lua/log: do not allow to set json for boot logger Cyrill Gorcunov
2020-06-02 7:51 ` Oleg Babin
2020-06-02 8:17 ` Cyrill Gorcunov
2020-06-03 9:44 ` Kirill Yukhin
2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 06/11] lua/log: declare log as separate variable Cyrill Gorcunov
2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 07/11] lua/log: use log module settings inside box.cfg Cyrill Gorcunov
2020-06-02 7:51 ` Oleg Babin
2020-06-02 8:15 ` Cyrill Gorcunov
2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 08/11] lua/log: allow to configure logging without a box Cyrill Gorcunov
2020-06-02 7:51 ` Oleg Babin
2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 09/11] test: use direct log module Cyrill Gorcunov
2020-06-02 7:52 ` Oleg Babin
2020-06-02 8:13 ` Cyrill Gorcunov
2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 10/11] log/lua: allow to specify logging level as a string Cyrill Gorcunov
2020-06-02 7:52 ` Oleg Babin
2020-06-02 8:05 ` Oleg Babin
2020-06-02 8:12 ` Cyrill Gorcunov
2020-06-01 22:25 ` [Tarantool-patches] [PATCH v7 11/11] lua/log: use log_cfg instead of ffi's instances Cyrill Gorcunov
2020-06-02 7:52 ` Oleg Babin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601222507.560415-1-gorcunov@gmail.com \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v7 00/11] lua/log: add an ability to setup logger without box.cfg{}' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox