* [Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua
@ 2020-05-31 5:12 Alexander V. Tikhonov
2020-06-01 10:47 ` Alexander Turenko
0 siblings, 1 reply; 6+ messages in thread
From: Alexander V. Tikhonov @ 2020-05-31 5:12 UTC (permalink / raw)
To: Sergey Bronnikov, Alexander Turenko; +Cc: Oleg Piskunov, tarantool-patches
During investigation of the issues found that error message had
not user friendly format:
local pwgr_errstr = "get%s failed [errno %d]: %s"
produced:
[001] LuajitError: builtin/pwd.lua:101: getgetgrall failed [errno 2]: No such file or directory
while it had to be:
[001] LuajitError: builtin/pwd.lua:101: get getgrall failed [errno 2]: No such file or directory
Fixed the error message.
---
Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4592-enoent-pwd-full-ci
src/lua/pwd.lua | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lua/pwd.lua b/src/lua/pwd.lua
index d59594b46..1ea79b5eb 100644
--- a/src/lua/pwd.lua
+++ b/src/lua/pwd.lua
@@ -86,7 +86,7 @@ ffi.cdef[[
-- {{{ Error handling
-local pwgr_errstr = "get%s failed [errno %d]: %s"
+local pwgr_errstr = "get %s failed [errno %d]: %s"
-- Use it in the following way: set errno to zero, call a passwd /
-- group function, then call this function to check whether there
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua
2020-05-31 5:12 [Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua Alexander V. Tikhonov
@ 2020-06-01 10:47 ` Alexander Turenko
2020-06-03 11:37 ` Alexander V. Tikhonov
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Turenko @ 2020-06-01 10:47 UTC (permalink / raw)
To: Alexander V. Tikhonov; +Cc: Oleg Piskunov, tarantool-patches
On Sun, May 31, 2020 at 08:12:42AM +0300, Alexander V. Tikhonov wrote:
> During investigation of the issues found that error message had
> not user friendly format:
> local pwgr_errstr = "get%s failed [errno %d]: %s"
> produced:
> [001] LuajitError: builtin/pwd.lua:101: getgetgrall failed [errno 2]: No such file or directory
> while it had to be:
> [001] LuajitError: builtin/pwd.lua:101: get getgrall failed [errno 2]: No such file or directory
> Fixed the error message.
My bad, looks as regression from
6c5d3f060459c943bbba8394e7f1f91f79efb5a6 ('lua: pwd: split data fetch
from deserialization').
LGTM, but, please, make it just 'getgrall failed [errno 2]: No such file
or directory', without leading 'get'.
WBR, Alexander Turenko.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua
2020-06-01 10:47 ` Alexander Turenko
@ 2020-06-03 11:37 ` Alexander V. Tikhonov
0 siblings, 0 replies; 6+ messages in thread
From: Alexander V. Tikhonov @ 2020-06-03 11:37 UTC (permalink / raw)
To: Alexander Turenko; +Cc: tarantool-patches
Hi Alexander, thanks for the review, I've changed it as you suggested.
On Mon, Jun 01, 2020 at 01:47:56PM +0300, Alexander Turenko wrote:
> On Sun, May 31, 2020 at 08:12:42AM +0300, Alexander V. Tikhonov wrote:
> > During investigation of the issues found that error message had
> > not user friendly format:
> > local pwgr_errstr = "get%s failed [errno %d]: %s"
> > produced:
> > [001] LuajitError: builtin/pwd.lua:101: getgetgrall failed [errno 2]: No such file or directory
> > while it had to be:
> > [001] LuajitError: builtin/pwd.lua:101: get getgrall failed [errno 2]: No such file or directory
> > Fixed the error message.
>
> My bad, looks as regression from
> 6c5d3f060459c943bbba8394e7f1f91f79efb5a6 ('lua: pwd: split data fetch
> from deserialization').
>
> LGTM, but, please, make it just 'getgrall failed [errno 2]: No such file
> or directory', without leading 'get'.
>
> WBR, Alexander Turenko.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua
2020-05-31 5:09 Alexander V. Tikhonov
2020-06-01 8:57 ` Sergey Bronnikov
@ 2020-06-03 10:13 ` Kirill Yukhin
1 sibling, 0 replies; 6+ messages in thread
From: Kirill Yukhin @ 2020-06-03 10:13 UTC (permalink / raw)
To: Alexander V. Tikhonov; +Cc: Oleg Piskunov, tarantool-patches, Alexander Turenko
Hello,
On 31 май 08:09, Alexander V. Tikhonov wrote:
> Durring investigation of the issues found that error message had
> not user friendly format:
> local pwgr_errstr = "get%s failed [errno %d]: %s"
> produced:
> [001] LuajitError: builtin/pwd.lua:101: getgetgrall failed [errno 2]: No such file or directory
> while it had to be:
> [001] LuajitError: builtin/pwd.lua:101: get getgrall failed [errno 2]: No such file or directory
> Fixed the error message.
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4592-enoent-pwd-full-ci
I've checked your patch into 1.10, 2.3, 2.4 and master.
--
Regards, Kirill Yukhin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua
2020-05-31 5:09 Alexander V. Tikhonov
@ 2020-06-01 8:57 ` Sergey Bronnikov
2020-06-03 10:13 ` Kirill Yukhin
1 sibling, 0 replies; 6+ messages in thread
From: Sergey Bronnikov @ 2020-06-01 8:57 UTC (permalink / raw)
To: Alexander V. Tikhonov; +Cc: Oleg Piskunov, tarantool-patches, Alexander Turenko
LGTM as obvious
On 08:09 Sun 31 May , Alexander V. Tikhonov wrote:
> Durring investigation of the issues found that error message had
> not user friendly format:
> local pwgr_errstr = "get%s failed [errno %d]: %s"
> produced:
> [001] LuajitError: builtin/pwd.lua:101: getgetgrall failed [errno 2]: No such file or directory
> while it had to be:
> [001] LuajitError: builtin/pwd.lua:101: get getgrall failed [errno 2]: No such file or directory
> Fixed the error message.
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4592-enoent-pwd-full-ci
>
> src/lua/pwd.lua | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lua/pwd.lua b/src/lua/pwd.lua
> index d59594b46..1ea79b5eb 100644
> --- a/src/lua/pwd.lua
> +++ b/src/lua/pwd.lua
> @@ -86,7 +86,7 @@ ffi.cdef[[
>
> -- {{{ Error handling
>
> -local pwgr_errstr = "get%s failed [errno %d]: %s"
> +local pwgr_errstr = "get %s failed [errno %d]: %s"
>
> -- Use it in the following way: set errno to zero, call a passwd /
> -- group function, then call this function to check whether there
> --
> 2.17.1
>
--
sergeyb@
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua
@ 2020-05-31 5:09 Alexander V. Tikhonov
2020-06-01 8:57 ` Sergey Bronnikov
2020-06-03 10:13 ` Kirill Yukhin
0 siblings, 2 replies; 6+ messages in thread
From: Alexander V. Tikhonov @ 2020-05-31 5:09 UTC (permalink / raw)
To: Sergey Bronnikov, Alexander Turenko; +Cc: Oleg Piskunov, tarantool-patches
Durring investigation of the issues found that error message had
not user friendly format:
local pwgr_errstr = "get%s failed [errno %d]: %s"
produced:
[001] LuajitError: builtin/pwd.lua:101: getgetgrall failed [errno 2]: No such file or directory
while it had to be:
[001] LuajitError: builtin/pwd.lua:101: get getgrall failed [errno 2]: No such file or directory
Fixed the error message.
---
Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4592-enoent-pwd-full-ci
src/lua/pwd.lua | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lua/pwd.lua b/src/lua/pwd.lua
index d59594b46..1ea79b5eb 100644
--- a/src/lua/pwd.lua
+++ b/src/lua/pwd.lua
@@ -86,7 +86,7 @@ ffi.cdef[[
-- {{{ Error handling
-local pwgr_errstr = "get%s failed [errno %d]: %s"
+local pwgr_errstr = "get %s failed [errno %d]: %s"
-- Use it in the following way: set errno to zero, call a passwd /
-- group function, then call this function to check whether there
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-06-03 11:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-31 5:12 [Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua Alexander V. Tikhonov
2020-06-01 10:47 ` Alexander Turenko
2020-06-03 11:37 ` Alexander V. Tikhonov
-- strict thread matches above, loose matches on Subject: below --
2020-05-31 5:09 Alexander V. Tikhonov
2020-06-01 8:57 ` Sergey Bronnikov
2020-06-03 10:13 ` Kirill Yukhin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox