From: Igor Munkin <imun@tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org,
v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v6 03/25] gitlab-ci: enable static analysis with luacheck
Date: Mon, 1 Jun 2020 12:48:50 +0300 [thread overview]
Message-ID: <20200601094850.GP21558@tarantool.org> (raw)
In-Reply-To: <20200601092957.GA37818@pony.bronevichok.ru>
Sergey,
On 01.06.20, Sergey Bronnikov wrote:
> Igor,
>
> thanks for review!
>
> On 22:25 Fri 29 May , Igor Munkin wrote:
> > Sergey,
> >
> > Thanks for the patch! It LGTM, except the one comment: I'm not a Gitlab
> > CI expert but since you introduced a separate make rule for luacheck, it
> > looks like you can use it also in CI. As a result of such change we have
> > a single place where luacheck command is mentioned excplicitly in our
> > project, that simplifies further maintenance.
>
> You are right, it is a piece of duplicated code. But in a CI I don't use
> tarantool build infrastructure at all, because we don't need to build
> tarantool to check Lua code used in it. Let me know if you have an ideas
> how to share luacheck command line with CMakeLists.txt and GitLab CI
> config.
Yes, you don't need to build tarantool, just to configure it. But I
totally don't insist and leave this question for more competent CI
users.
>
<snipped>
>
> --
> sergeyb@
--
Best regards,
IM
next prev parent reply other threads:[~2020-06-01 9:57 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 15:08 [Tarantool-patches] [PATCH v6 00/25] Add " sergeyb
2020-05-29 15:08 ` [Tarantool-patches] [PATCH v6 01/25] Add initial luacheck config sergeyb
2020-05-29 16:04 ` Igor Munkin
2020-05-29 16:27 ` Igor Munkin
2020-05-30 12:19 ` Sergey Bronnikov
2020-05-30 12:18 ` Sergey Bronnikov
2020-05-29 15:08 ` [Tarantool-patches] [PATCH v6 02/25] build: enable 'make luacheck' target sergeyb
2020-05-29 16:28 ` Igor Munkin
2020-05-29 15:08 ` [Tarantool-patches] [PATCH v6 03/25] gitlab-ci: enable static analysis with luacheck sergeyb
2020-05-29 19:25 ` Igor Munkin
2020-06-01 9:29 ` Sergey Bronnikov
2020-06-01 9:48 ` Igor Munkin [this message]
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 04/25] Fix luacheck warnings in extra/dist/tarantoolctl.in sergeyb
2020-05-29 16:35 ` Igor Munkin
2020-06-01 14:10 ` Alexander Turenko
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 05/25] Fix luacheck warnings in src/lua/ sergeyb
2020-05-29 16:51 ` Igor Munkin
2020-05-29 19:13 ` Igor Munkin
2020-05-30 12:15 ` Sergey Bronnikov
2020-06-01 9:43 ` Igor Munkin
2020-06-01 10:36 ` Sergey Bronnikov
2020-06-01 9:38 ` Sergey Bronnikov
2020-06-01 14:47 ` Alexander Turenko
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 06/25] Fix luacheck warnings in src/box/lua/ sergeyb
2020-05-29 19:11 ` Igor Munkin
2020-05-30 12:22 ` Sergey Bronnikov
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 07/25] Supress luacheck warnings in test/app sergeyb
2020-06-01 10:11 ` Igor Munkin
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 08/25] Fix luacheck warnings in test/app-tap sergeyb
2020-06-01 11:41 ` Igor Munkin
2020-07-16 11:44 ` Sergey Bronnikov
2020-07-16 12:42 ` Igor Munkin
2020-07-16 13:25 ` Sergey Bronnikov
2020-06-01 13:37 ` Alexander Turenko
2020-06-01 16:37 ` Igor Munkin
2020-06-01 17:13 ` Alexander Turenko
2020-06-01 17:38 ` Igor Munkin
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 09/25] Fix luacheck warnings in test/box sergeyb
2020-06-01 16:06 ` Igor Munkin
2020-07-16 13:23 ` Sergey Bronnikov
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 10/25] Fix luacheck warnings in test/box-py sergeyb
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 11/25] Fix luacheck warnings in test/box-tap sergeyb
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 12/25] Fix luacheck warnings in test/engine sergeyb
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 13/25] Fix luacheck warnings in test/engine_long sergeyb
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 14/25] Fix luacheck warnings in test/long_run-py sergeyb
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 15/25] Fix luacheck warnings in test/replication sergeyb
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 16/25] Fix luacheck warnings in test/replication-py sergeyb
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 17/25] Fix luacheck warnings in test/sql sergeyb
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 18/25] Fix luacheck warnings in test/sql-tap sergeyb
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 19/25] Fix luacheck warnings in test/swim sergeyb
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 20/25] Fix luacheck warnings in test/vinyl sergeyb
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 21/25] Fix luacheck warnings in test/wal_off sergeyb
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 22/25] Fix luacheck warnings in test/xlog sergeyb
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 23/25] Fix luacheck warnings in test/xlog-py sergeyb
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 24/25] Add luacheck supressions for luajit tests sergeyb
2020-05-29 15:09 ` [Tarantool-patches] [PATCH v6 25/25] luajit: bump new version sergeyb
2020-06-01 17:08 ` [Tarantool-patches] [PATCH v6 00/25] Add static analysis with luacheck Vladislav Shpilevoy
2020-06-01 17:29 ` Alexander Turenko
2020-06-01 18:13 ` Igor Munkin
2020-06-02 14:42 ` Alexander Turenko
2020-06-02 15:58 ` Igor Munkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601094850.GP21558@tarantool.org \
--to=imun@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=o.piskunov@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v6 03/25] gitlab-ci: enable static analysis with luacheck' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox