[Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua

[Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua

[Alexander V. Tikhonov]

Durring investigation of the issues found that error message had
not user friendly format:
 local pwgr_errstr = "get%s failed [errno %d]: %s"
produced:
 [001] LuajitError: builtin/pwd.lua:101: getgetgrall failed [errno 2]: No such file or directory
while it had to be:
 [001] LuajitError: builtin/pwd.lua:101: get getgrall failed [errno 2]: No such file or directory
Fixed the error message.
---

Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4592-enoent-pwd-full-ci

 src/lua/pwd.lua | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lua/pwd.lua b/src/lua/pwd.lua
index d59594b46..1ea79b5eb 100644
--- a/src/lua/pwd.lua
+++ b/src/lua/pwd.lua
@@ -86,7 +86,7 @@ ffi.cdef[[
 
 -- {{{ Error handling
 
-local pwgr_errstr = "get%s failed [errno %d]: %s"
+local pwgr_errstr = "get %s failed [errno %d]: %s"
 
 -- Use it in the following way: set errno to zero, call a passwd /
 -- group function, then call this function to check whether there
-- 
2.17.1

[Tarantool-patches] [PATCH v1 2/2] test: remove skip condition of app-tap/pwd test

[Alexander V. Tikhonov]

During creating patch:

  e3d9d8c97edd39438cbc98fccac996e61ce4984c ("build: add CentOS 8 into CI / CD")

was found the issue:

  [001] app-tap/pwd.test.lua                                            [ fail ]
  [001] Test failed! Output from reject file app-tap/pwd.reject:
  [001] TAP version 13
  [001] 1..6
  [001] ok - checking user by id
  [001] ok - checking user by name
  [001] ok - checking group by id
  [001] ok - checking group by name
  [001]
  [001] Last 15 lines of Tarantool Log file [Instance "app_server"][/mnt/test/var/001_app-tap/pwd.test.lua.tarantool.log]:
  [001] tarantool: /lib64/libcurl.so.4: no version information available (required by tarantool)
  [001] builtin/pwd.lua:169: getpwall failed [errno 2]: No such file or directory

Currently it was tried to reproduce the issue, but all the attempts
didn't got the needed fail. After discussion of the issue decided to
close the current one as not the issue for the test and continue the
fixes for getpwall/getgrall functions within issue #5034.

Closes #4592
---

Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4592-enoent-pwd-full-ci
Issue: https://github.com/tarantool/tarantool/issues/4592

 test/app-tap/pwd.skipcond | 11 -----------
 1 file changed, 11 deletions(-)
 delete mode 100644 test/app-tap/pwd.skipcond

diff --git a/test/app-tap/pwd.skipcond b/test/app-tap/pwd.skipcond
deleted file mode 100644
index cf97461bc..000000000
--- a/test/app-tap/pwd.skipcond
+++ /dev/null
@@ -1,11 +0,0 @@
-import subprocess
-
-# Disable the test on CentOS 8 until gh-4592 will be resolved.
-try:
-    cmd = ['rpm', '--eval', '%{centos_ver}']
-    if subprocess.check_output(cmd).strip() == '8':
-        self.skip = 1
-except:
-    pass
-
-# vim: set ft=python:
-- 
2.17.1

Re: [Tarantool-patches] [PATCH v1 2/2] test: remove skip condition of app-tap/pwd test

[Sergey Bronnikov]

LGTM

On 08:09 Sun 31 May , Alexander V. Tikhonov wrote:
> During creating patch:
> 
>   e3d9d8c97edd39438cbc98fccac996e61ce4984c ("build: add CentOS 8 into CI / CD")
> 
> was found the issue:
> 
>   [001] app-tap/pwd.test.lua                                            [ fail ]
>   [001] Test failed! Output from reject file app-tap/pwd.reject:
>   [001] TAP version 13
>   [001] 1..6
>   [001] ok - checking user by id
>   [001] ok - checking user by name
>   [001] ok - checking group by id
>   [001] ok - checking group by name
>   [001]
>   [001] Last 15 lines of Tarantool Log file [Instance "app_server"][/mnt/test/var/001_app-tap/pwd.test.lua.tarantool.log]:
>   [001] tarantool: /lib64/libcurl.so.4: no version information available (required by tarantool)
>   [001] builtin/pwd.lua:169: getpwall failed [errno 2]: No such file or directory
> 
> Currently it was tried to reproduce the issue, but all the attempts
> didn't got the needed fail. After discussion of the issue decided to
> close the current one as not the issue for the test and continue the
> fixes for getpwall/getgrall functions within issue #5034.
> 
> Closes #4592
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4592-enoent-pwd-full-ci
> Issue: https://github.com/tarantool/tarantool/issues/4592
> 
>  test/app-tap/pwd.skipcond | 11 -----------
>  1 file changed, 11 deletions(-)
>  delete mode 100644 test/app-tap/pwd.skipcond
> 
> diff --git a/test/app-tap/pwd.skipcond b/test/app-tap/pwd.skipcond
> deleted file mode 100644
> index cf97461bc..000000000
> --- a/test/app-tap/pwd.skipcond
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -import subprocess
> -
> -# Disable the test on CentOS 8 until gh-4592 will be resolved.
> -try:
> -    cmd = ['rpm', '--eval', '%{centos_ver}']
> -    if subprocess.check_output(cmd).strip() == '8':
> -        self.skip = 1
> -except:
> -    pass
> -
> -# vim: set ft=python:
> -- 
> 2.17.1
> 

-- 
sergeyb@

Re: [Tarantool-patches] [PATCH v1 2/2] test: remove skip condition of app-tap/pwd test

[Alexander Turenko]

LGTM.

On Sun, May 31, 2020 at 08:09:42AM +0300, Alexander V. Tikhonov wrote:
> During creating patch:
> 
>   e3d9d8c97edd39438cbc98fccac996e61ce4984c ("build: add CentOS 8 into CI / CD")
> 
> was found the issue:
> 
>   [001] app-tap/pwd.test.lua                                            [ fail ]
>   [001] Test failed! Output from reject file app-tap/pwd.reject:
>   [001] TAP version 13
>   [001] 1..6
>   [001] ok - checking user by id
>   [001] ok - checking user by name
>   [001] ok - checking group by id
>   [001] ok - checking group by name
>   [001]
>   [001] Last 15 lines of Tarantool Log file [Instance "app_server"][/mnt/test/var/001_app-tap/pwd.test.lua.tarantool.log]:
>   [001] tarantool: /lib64/libcurl.so.4: no version information available (required by tarantool)
>   [001] builtin/pwd.lua:169: getpwall failed [errno 2]: No such file or directory
> 
> Currently it was tried to reproduce the issue, but all the attempts
> didn't got the needed fail. After discussion of the issue decided to
> close the current one as not the issue for the test and continue the
> fixes for getpwall/getgrall functions within issue #5034.
> 
> Closes #4592
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4592-enoent-pwd-full-ci
> Issue: https://github.com/tarantool/tarantool/issues/4592
> 
>  test/app-tap/pwd.skipcond | 11 -----------
>  1 file changed, 11 deletions(-)
>  delete mode 100644 test/app-tap/pwd.skipcond
> 
> diff --git a/test/app-tap/pwd.skipcond b/test/app-tap/pwd.skipcond
> deleted file mode 100644
> index cf97461bc..000000000
> --- a/test/app-tap/pwd.skipcond
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -import subprocess
> -
> -# Disable the test on CentOS 8 until gh-4592 will be resolved.
> -try:
> -    cmd = ['rpm', '--eval', '%{centos_ver}']
> -    if subprocess.check_output(cmd).strip() == '8':
> -        self.skip = 1
> -except:
> -    pass
> -
> -# vim: set ft=python:
> -- 
> 2.17.1
> 

Re: [Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua

[Sergey Bronnikov]

LGTM as obvious

On 08:09 Sun 31 May , Alexander V. Tikhonov wrote:
> Durring investigation of the issues found that error message had
> not user friendly format:
>  local pwgr_errstr = "get%s failed [errno %d]: %s"
> produced:
>  [001] LuajitError: builtin/pwd.lua:101: getgetgrall failed [errno 2]: No such file or directory
> while it had to be:
>  [001] LuajitError: builtin/pwd.lua:101: get getgrall failed [errno 2]: No such file or directory
> Fixed the error message.
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4592-enoent-pwd-full-ci
> 
>  src/lua/pwd.lua | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lua/pwd.lua b/src/lua/pwd.lua
> index d59594b46..1ea79b5eb 100644
> --- a/src/lua/pwd.lua
> +++ b/src/lua/pwd.lua
> @@ -86,7 +86,7 @@ ffi.cdef[[
>  
>  -- {{{ Error handling
>  
> -local pwgr_errstr = "get%s failed [errno %d]: %s"
> +local pwgr_errstr = "get %s failed [errno %d]: %s"
>  
>  -- Use it in the following way: set errno to zero, call a passwd /
>  -- group function, then call this function to check whether there
> -- 
> 2.17.1
> 

-- 
sergeyb@

Re: [Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua

[Kirill Yukhin]

Hello,

On 31 май 08:09, Alexander V. Tikhonov wrote:
> Durring investigation of the issues found that error message had
> not user friendly format:
>  local pwgr_errstr = "get%s failed [errno %d]: %s"
> produced:
>  [001] LuajitError: builtin/pwd.lua:101: getgetgrall failed [errno 2]: No such file or directory
> while it had to be:
>  [001] LuajitError: builtin/pwd.lua:101: get getgrall failed [errno 2]: No such file or directory
> Fixed the error message.
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4592-enoent-pwd-full-ci

I've checked your patch into 1.10, 2.3, 2.4 and master.

--
Regards, Kirill Yukhin

[Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua

[Alexander V. Tikhonov]

During investigation of the issues found that error message had
not user friendly format:
 local pwgr_errstr = "get%s failed [errno %d]: %s"
produced:
 [001] LuajitError: builtin/pwd.lua:101: getgetgrall failed [errno 2]: No such file or directory
while it had to be:
 [001] LuajitError: builtin/pwd.lua:101: get getgrall failed [errno 2]: No such file or directory
Fixed the error message.
---

Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4592-enoent-pwd-full-ci

 src/lua/pwd.lua | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lua/pwd.lua b/src/lua/pwd.lua
index d59594b46..1ea79b5eb 100644
--- a/src/lua/pwd.lua
+++ b/src/lua/pwd.lua
@@ -86,7 +86,7 @@ ffi.cdef[[
 
 -- {{{ Error handling
 
-local pwgr_errstr = "get%s failed [errno %d]: %s"
+local pwgr_errstr = "get %s failed [errno %d]: %s"
 
 -- Use it in the following way: set errno to zero, call a passwd /
 -- group function, then call this function to check whether there
-- 
2.17.1

Re: [Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua

[Alexander Turenko]

On Sun, May 31, 2020 at 08:12:42AM +0300, Alexander V. Tikhonov wrote:
> During investigation of the issues found that error message had
> not user friendly format:
>  local pwgr_errstr = "get%s failed [errno %d]: %s"
> produced:
>  [001] LuajitError: builtin/pwd.lua:101: getgetgrall failed [errno 2]: No such file or directory
> while it had to be:
>  [001] LuajitError: builtin/pwd.lua:101: get getgrall failed [errno 2]: No such file or directory
> Fixed the error message.

My bad, looks as regression from
6c5d3f060459c943bbba8394e7f1f91f79efb5a6 ('lua: pwd: split data fetch
from deserialization').

LGTM, but, please, make it just 'getgrall failed [errno 2]: No such file
or directory', without leading 'get'.

WBR, Alexander Turenko.

Re: [Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua

[Alexander V. Tikhonov]

Hi Alexander, thanks for the review, I've changed it as you suggested.

On Mon, Jun 01, 2020 at 01:47:56PM +0300, Alexander Turenko wrote:
> On Sun, May 31, 2020 at 08:12:42AM +0300, Alexander V. Tikhonov wrote:
> > During investigation of the issues found that error message had
> > not user friendly format:
> >  local pwgr_errstr = "get%s failed [errno %d]: %s"
> > produced:
> >  [001] LuajitError: builtin/pwd.lua:101: getgetgrall failed [errno 2]: No such file or directory
> > while it had to be:
> >  [001] LuajitError: builtin/pwd.lua:101: get getgrall failed [errno 2]: No such file or directory
> > Fixed the error message.
> 
> My bad, looks as regression from
> 6c5d3f060459c943bbba8394e7f1f91f79efb5a6 ('lua: pwd: split data fetch
> from deserialization').
> 
> LGTM, but, please, make it just 'getgrall failed [errno 2]: No such file
> or directory', without leading 'get'.
> 
> WBR, Alexander Turenko.