Re: [Tarantool-patches] [PATCH v6 01/25] Add initial luacheck config

[Sergey Bronnikov <sergeyb@tarantool.org>]

Igor,

thanks for review!

On 19:04 Fri 29 May , Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch! Here is my comment from previous series[1]:
> | Several chunks in test/vinyl/ directory are not diff-based tests but
> | either instance configs (e.g. test/vinyl/vinyl.lua) or auxiliary modules
> | (e.g. test/vinyl/large.lua). I guess we need to check at least the
> | latter ones.
> 
> I meant to change file mask for *all* test/ subdirectories in exclude
> list the following way: s/\*.lua$/\*.test.lua/g.

File masks updated and new warnings has been fixed. New changes are in
commits with message headers like "Update file mask...".

> Otherwise, LGTM.
> 
> On 29.05.20, sergeyb@tarantool.org wrote:
> > From: Sergey Bronnikov <sergeyb@tarantool.org>
> > 
> > config includes all files with Lua source code except:
> > - third_party repositories
> > - directories with diff-based tests
> > 
> > How-to check:
> > 
> > $ tarantoolctl rocks install luacheck
> > $ .rocks/bin/luacheck --codes --config .luacheckrc .
> > 
> > Part of #4681
> > 
> > Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> > Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> > ---
> >  .luacheckrc | 25 +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> >  create mode 100644 .luacheckrc
> > 
> 
> <snipped>
> 
> > -- 
> > 2.23.0
> > 
> 
> [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-May/017073.html
> 
> -- 
> Best regards,
> IM

-- 
sergeyb@