From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] vinyl: add NULL check of xrow_upsert_execute() retval
Date: Sat, 30 May 2020 02:04:43 +0300 [thread overview]
Message-ID: <20200529230443.GA209500@atlas> (raw)
In-Reply-To: <7445b38c-f664-ca79-bb05-73a73ddc4d6d@tarantool.org>
* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [20/05/30 00:29]:
> I don't know how to fix it in a simple way. The only thing I could
> come up with is probably don't squash such fat upserts. Just keep
> them all on the disk, until they eventually meet bottom of their key,
> or a terminal statement like REPLACE/INSERT/DELETE.
I wrote earlier about this problem in @tarantoolru.
We need to balance the op limit and the squash threshold (how many
upserts we keep before forcing a squash) so that
accumulation before squash can never lead to going out of the op limit.
Basically, we should force squash before we have a chance of
creating an invalid upsert.
We could even have a separate constant - number of ops in *user*
upsert, which ==
max_number_of_ops/max_upserts_before_forced_squash.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-05-29 23:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 2:56 Nikita Pettik
2020-05-29 21:24 ` Vladislav Shpilevoy
2020-05-29 21:34 ` Vladislav Shpilevoy
2020-07-08 12:22 ` Nikita Pettik
2020-05-29 23:04 ` Konstantin Osipov [this message]
2020-07-08 12:53 ` Nikita Pettik
2020-07-09 11:56 ` Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529230443.GA209500@atlas \
--to=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] vinyl: add NULL check of xrow_upsert_execute() retval' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox