From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Leonid Vasiliev <lvasiliev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH V2] socket: fix error while closing socket.tcp_server
Date: Fri, 29 May 2020 15:41:31 +0300 [thread overview]
Message-ID: <20200529124131.lvah6pioq7zydm7k@tkn_work_nb> (raw)
In-Reply-To: <5f4f3b47886fa74ab4c8fa19cbe77d80ed67b4b6.1589918392.git.lvasiliev@tarantool.org>
On Tue, May 19, 2020 at 11:05:25PM +0300, Leonid Vasiliev wrote:
> The tcp server starts in a separate fiber.
> When server's socket is closed from another fiber,
> an exception will be thrown in server's loop from
> check_socket function.
> A "socket is close" check has been added at server's
> fiber and now server's fiber terminates correctly.
>
> Fixes: #4087
> ---
> https://github.com/tarantool/tarantool/issues/4087
> https://github.com/tarantool/tarantool/tree/lvasiliev/gh-4087-fix-socket-stuff
>
> @Changelog fix error while closing socket.tcp_server socket(gh-4087)
>
> For a "socket is close" check, fd < 0 is used instead of an additional flag.
LGTM.
next prev parent reply other threads:[~2020-05-29 12:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 20:05 Leonid Vasiliev
2020-05-29 12:41 ` Alexander Turenko [this message]
2020-06-01 15:11 ` Ilya Kosarev
2020-06-02 14:54 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529124131.lvah6pioq7zydm7k@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=lvasiliev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH V2] socket: fix error while closing socket.tcp_server' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox