Re: [Tarantool-patches] [PATCH v5 08/10] Fix luacheck warnings in test/

[Igor Munkin <imun@tarantool.org>]

Sergey,

Thanks for the patch! The patch is huge, so please split it into
several, as we discussed. Nevertheless, I checked test/app-tap
directory, please consider my comments below.

On 12.05.20, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> Closes #4681
> 
> Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Reviewed-by: Igor Munkin <imun@tarantool.org>
> 
> Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Co-authored-by: Igor Munkin <imun@tarantool.org>
> ---
>  .luacheckrc                                   |  29 +-
>  test/app-tap/cfg.test.lua                     |   2 +-
>  test/app-tap/clock.test.lua                   |   4 +-
>  test/app-tap/console.test.lua                 |  16 +-
>  test/app-tap/console_lua.test.lua             |  22 +-
>  test/app-tap/csv.test.lua                     |  56 +-
>  test/app-tap/debug.test.lua                   |  10 +-
>  test/app-tap/errno.test.lua                   |  24 +-
>  test/app-tap/fail_main.test.lua               |   6 +-
>  .../gh-4761-json-per-call-options.test.lua    |  11 +-
>  test/app-tap/http_client.test.lua             | 297 +++++------
>  test/app-tap/iconv.test.lua                   |   6 +-
>  test/app-tap/init_script.test.lua             |  14 +-
>  test/app-tap/inspector.test.lua               |   5 +-
>  test/app-tap/json.test.lua                    |   1 -
>  test/app-tap/logger.test.lua                  |  21 +-
>  test/app-tap/minimal.test.lua                 |   4 +-
>  test/app-tap/module_api.test.lua              |  12 +-
>  test/app-tap/msgpackffi.test.lua              |   3 +-
>  test/app-tap/pcall.test.lua                   |   6 +-
>  test/app-tap/popen.test.lua                   |  35 +-
>  test/app-tap/snapshot.test.lua                |  17 +-
>  test/app-tap/string.test.lua                  | 502 +++++++++---------
>  test/app-tap/tap.test.lua                     |  26 +-
>  test/app-tap/tarantoolctl.test.lua            |  82 ++-
>  test/app-tap/trigger.test.lua                 |  48 +-
>  test/app-tap/yaml.test.lua                    |  16 +-

<snipped>

>  168 files changed, 1145 insertions(+), 1233 deletions(-)
> 
> diff --git a/.luacheckrc b/.luacheckrc
> index e5c4c4509..26986ffb1 100644
> --- a/.luacheckrc
> +++ b/.luacheckrc
> @@ -6,18 +6,18 @@ include_files = {

<snipped>

There is still a mess with suppressions, so I added the relevant ones
from the branch:

| files["test/app-tap/lua/require_mod.lua"] = {globals = {"exports"}}
| files["test/app-tap/module_api.test.lua"] = {ignore = {"311"}}

The suppression above seems to be excess and can be dropped.

| files["test/app-tap/string.test.lua"] = {globals = {"utf8"}}

<snipped>

> diff --git a/test/app-tap/string.test.lua b/test/app-tap/string.test.lua
> index 02a1a84d7..be489fbc2 100755
> --- a/test/app-tap/string.test.lua
> +++ b/test/app-tap/string.test.lua

<snipped>

> @@ -304,70 +304,70 @@ test:test("unicode", function(test)

<snipped>

>  
>      local s1 = '☢'
>      local s2 = 'İ'
> -    test:is(s1 < s2, false, 'test binary cmp')
> -    test:is(utf8.cmp(s1, s2) < 0, true, 'test unicode <')
> -    test:is(utf8.cmp(s1, s1) == 0, true, 'test unicode eq')
> -    test:is(utf8.cmp(s2, s1) > 0, true, 'test unicode >')
> -    test:is(utf8.casecmp('a', 'A') == 0, true, 'test icase ==')
> -    test:is(utf8.casecmp('b', 'A') > 0, true, 'test icase >, first')
> -    test:is(utf8.casecmp('B', 'a') > 0, true, 'test icase >, second >')
> -    test:is(utf8.cmp('', '') == 0, true, 'test empty compare')
> -    test:is(utf8.cmp('', 'a') < 0, true, 'test left empty compare')
> -    test:is(utf8.cmp('a', '') > 0, true, 'test right empty compare')
> -    test:is(utf8.casecmp('', '') == 0, true, 'test empty icompare')
> -    test:is(utf8.casecmp('', 'a') < 0, true, 'test left empty icompare')
> -    test:is(utf8.casecmp('a', '') > 0, true, 'test right empty icompare')
> +    testcase:is(s1 < s2, false, 'testcase binary cmp')
> +    testcase:is(utf8.cmp(s1, s2) < 0, true, 'testcase unicode <')
> +    testcase:is(utf8.cmp(s1, s1) == 0, true, 'testcase unicode eq')
> +    testcase:is(utf8.cmp(s2, s1) > 0, true, 'testcase unicode >')
> +    testcase:is(utf8.casecmp('a', 'A') == 0, true, 'testcase icase ==')
> +    testcase:is(utf8.casecmp('b', 'A') > 0, true, 'testcase icase >, first')
> +    testcase:is(utf8.casecmp('B', 'a') > 0, true, 'testcase icase >, second >')
> +    testcase:is(utf8.cmp('', '') == 0, true, 'testcase empty compare')
> +    testcase:is(utf8.cmp('', 'a') < 0, true, 'testcase left empty compare')
> +    testcase:is(utf8.cmp('a', '') > 0, true, 'testcase right empty compare')
> +    testcase:is(utf8.casecmp('', '') == 0, true, 'testcase empty icompare')
> +    testcase:is(utf8.casecmp('', 'a') < 0, true, 'testcase left empty icompare')
> +    testcase:is(utf8.casecmp('a', '') > 0, true, 'testcase right empty icompare')

You also sed-ed test message above.

<snipped>

> -- 
> 2.23.0
> 

-- 
Best regards,
IM