From: Cyrill Gorcunov <gorcunov@gmail.com> To: tml <tarantool-patches@dev.tarantool.org> Subject: [Tarantool-patches] [PATCH v4 0/8] lua/log: add an ability to setup logger without box.cfg{} Date: Thu, 28 May 2020 13:07:30 +0300 [thread overview] Message-ID: <20200528100738.221911-1-gorcunov@gmail.com> (raw) In the series we add an ability to configure logger early without calling box.cfg{}. The syntax is the same as in box.cfg{} call. There was an idea to implement something similar via triggers but I think this will require a way more efforts and code redesign, so at first lets stick to simplier solution. v2 by Oleg: - hide box_api symbols from users - initialize logger via log.cfg() call to look similar to box.cfg v3 by Oleg: - add parametesr verification - allow to reconfig via log.cfg() call v4 by Oleg: - lua style fixes - extent test (I didn't find a way to test wrong params verification inside tap test, so I did it manually. Still we might extent the test on top of the series). branch gorcunov/gh-689-logger-4 issue https://github.com/tarantool/tarantool/issues/689 Cyrill Gorcunov (8): core/say: do not reconfig early set up logger lua/log: declare say_logger_init and say_logger_initialized lua/log: put string constants to map lua/log: do not allow to set json for boot logger lua/log: declare log as separate variable lua/log: use log module settings inside box.cfg lua/log: allow to configure logging without a box test: use direct log module src/box/lua/load_cfg.lua | 24 +++- src/lib/core/say.c | 13 +++ src/lib/core/say.h | 4 + src/lua/log.lua | 216 +++++++++++++++++++++++++++++++---- test/app-tap/logger.test.lua | 28 ++++- 5 files changed, 255 insertions(+), 30 deletions(-) -- 2.26.2
next reply other threads:[~2020-05-28 10:07 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-28 10:07 Cyrill Gorcunov [this message] 2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 1/8] core/say: do not reconfig early set up logger Cyrill Gorcunov 2020-05-28 10:36 ` Oleg Babin 2020-05-28 10:42 ` lvasiliev 2020-05-28 10:47 ` Cyrill Gorcunov 2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 2/8] lua/log: declare say_logger_init and say_logger_initialized Cyrill Gorcunov 2020-05-28 10:37 ` Oleg Babin 2020-05-28 11:12 ` lvasiliev 2020-05-28 11:16 ` Cyrill Gorcunov 2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 3/8] lua/log: put string constants to map Cyrill Gorcunov 2020-05-28 10:37 ` Oleg Babin 2020-05-28 12:46 ` lvasiliev 2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 4/8] lua/log: do not allow to set json for boot logger Cyrill Gorcunov 2020-05-28 10:40 ` Oleg Babin 2020-05-28 10:48 ` Cyrill Gorcunov 2020-05-28 11:49 ` lvasiliev 2020-05-28 11:59 ` Cyrill Gorcunov 2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 5/8] lua/log: declare log as separate variable Cyrill Gorcunov 2020-05-28 10:40 ` Oleg Babin 2020-05-28 12:57 ` lvasiliev 2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 6/8] lua/log: use log module settings inside box.cfg Cyrill Gorcunov 2020-05-28 10:41 ` Oleg Babin 2020-05-28 10:49 ` Cyrill Gorcunov 2020-05-28 17:07 ` lvasiliev 2020-05-28 17:34 ` Cyrill Gorcunov 2020-05-29 8:43 ` Leonid Vasiliev 2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 7/8] lua/log: allow to configure logging without a box Cyrill Gorcunov 2020-05-28 10:42 ` Oleg Babin 2020-05-29 8:41 ` Leonid Vasiliev 2020-05-29 8:53 ` Oleg Babin 2020-05-29 9:16 ` Leonid Vasiliev 2020-05-29 9:49 ` Cyrill Gorcunov 2020-05-29 10:00 ` Oleg Babin 2020-05-29 10:22 ` Leonid Vasiliev 2020-05-29 10:38 ` Cyrill Gorcunov 2020-05-29 11:08 ` Leonid Vasiliev 2020-05-29 11:32 ` Cyrill Gorcunov 2020-05-29 11:39 ` Leonid Vasiliev 2020-05-29 10:07 ` Cyrill Gorcunov 2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 8/8] test: use direct log module Cyrill Gorcunov 2020-05-28 10:42 ` Oleg Babin 2020-05-28 10:50 ` Cyrill Gorcunov 2020-05-29 9:02 ` Leonid Vasiliev 2020-05-29 11:31 ` [Tarantool-patches] [PATCH v4 0/8] lua/log: add an ability to setup logger without box.cfg{} Leonid Vasiliev
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200528100738.221911-1-gorcunov@gmail.com \ --to=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v4 0/8] lua/log: add an ability to setup logger without box.cfg{}' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox