Re: [Tarantool-patches] [PATCH v5 04/10] Fix luacheck warnings in src/lua/

[Igor Munkin <imun@tarantool.org>]

Sergey,

Thanks for the patch! I propose to add suppressions also for the
remaining globals such as os, package in init.lua and help, tutorial in
help.lua to fix all warnings reported for src/lua directory in scope of
this patch.

Otherwise LGTM, as for the major patch.

On 12.05.20, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> Closes #4681
> 
> Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Reviewed-by: Igor Munkin <imun@tarantool.org>
> 
> Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Co-authored-by: Igor Munkin <imun@tarantool.org>
> ---
>  .luacheckrc | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/.luacheckrc b/.luacheckrc
> index f39502063..3cd05a254 100644
> --- a/.luacheckrc
> +++ b/.luacheckrc
> @@ -29,3 +29,6 @@ files["extra/dist/tarantoolctl.in"] = {
>  	globals = {"box", "_TARANTOOL"},
>  	ignore = {"212/self", "122", "431"}
>  }
> +files["src/lua/*.lua"] = {ignore = {"212/self"}}
> +files["src/lua/init.lua"] = {globals = {"dostring"}}
> +files["src/lua/swim.lua"] = {ignore = {"431"}}
> -- 
> 2.23.0
> 

-- 
Best regards,
IM