Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: tml <tarantool-patches@dev.tarantool.org>
Subject: [Tarantool-patches] [PATCH v3 10/10] test: use direct log module
Date: Wed, 27 May 2020 14:14:06 +0300	[thread overview]
Message-ID: <20200527111406.145422-11-gorcunov@gmail.com> (raw)
In-Reply-To: <20200527111406.145422-1-gorcunov@gmail.com>

To test if we can setup logging module before the box/cfg{}.

Part-of #689

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
 test/app-tap/logger.test.lua | 27 ++++++++++++++++++++++++---
 1 file changed, 24 insertions(+), 3 deletions(-)

diff --git a/test/app-tap/logger.test.lua b/test/app-tap/logger.test.lua
index 7bfa06e80..410220494 100755
--- a/test/app-tap/logger.test.lua
+++ b/test/app-tap/logger.test.lua
@@ -1,23 +1,44 @@
 #!/usr/bin/env tarantool
 
 local test = require('tap').test('log')
-test:plan(24)
+test:plan(27)
 
 -- gh-3946: Assertion failure when using log_format() before box.cfg()
 local log = require('log')
 log.log_format('plain')
 
+--
+-- gh-689: Operate with logger via log module without calling box.cfg{}
+local json = require('json')
+local filename = "1.log"
+
+log.cfg({log=filename, log_format='json', log_level=5})
+local m = "info message"
+
+local file = io.open(filename)
+while file:read() do
+end
+
+log.info(m)
+local line = file:read()
+local message = json.decode(line)
+file:close()
+
+test:is(type(message), 'table', "(log) json valid in log.info")
+test:is(message.level, "INFO", "(log) check type info")
+test:is(message.message, m, "(log) check message content")
+log.log_format('plain')
+
 --
 -- Check that Tarantool creates ADMIN session for #! script
 --
-local filename = "1.log"
 local message = "Hello, World!"
 box.cfg{
     log=filename,
+    log_format='plain',
     memtx_memory=107374182,
 }
 local fio = require('fio')
-local json = require('json')
 local fiber = require('fiber')
 local file = io.open(filename)
 while file:read() do
-- 
2.26.2

  parent reply	other threads:[~2020-05-27 11:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27 11:13 [Tarantool-patches] [PATCH v3 00/10] lua/log: add an ability to setup logger without box.cfg{} Cyrill Gorcunov
2020-05-27 11:13 ` [Tarantool-patches] [PATCH v3 01/10] core/say: drop redundant declarations Cyrill Gorcunov
2020-05-28  7:21   ` Kirill Yukhin
2020-05-27 11:13 ` [Tarantool-patches] [PATCH v3 02/10] core/say: drop vsay declaration Cyrill Gorcunov
2020-05-28  7:21   ` Kirill Yukhin
2020-05-27 11:13 ` [Tarantool-patches] [PATCH v3 03/10] core/say: do not reconfig early set up logger Cyrill Gorcunov
2020-05-27 11:14 ` [Tarantool-patches] [PATCH v3 04/10] lua/log: declare say_logger_init and say_logger_initialized Cyrill Gorcunov
2020-05-27 11:14 ` [Tarantool-patches] [PATCH v3 05/10] lua/log: put string constants to map Cyrill Gorcunov
2020-05-27 12:58   ` Oleg Babin
2020-05-27 11:14 ` [Tarantool-patches] [PATCH v3 06/10] lua/log: do not allow to set json for boot logger Cyrill Gorcunov
2020-05-27 11:14 ` [Tarantool-patches] [PATCH v3 07/10] lua/log: declare log as separate variable Cyrill Gorcunov
2020-05-27 12:58   ` Oleg Babin
2020-05-27 11:14 ` [Tarantool-patches] [PATCH v3 08/10] lua/log: use log module settings inside box.cfg Cyrill Gorcunov
2020-05-27 11:14 ` [Tarantool-patches] [PATCH v3 09/10] lua/log: allow to configure logging without a box Cyrill Gorcunov
2020-05-27 12:59   ` Oleg Babin
2020-05-27 11:14 ` Cyrill Gorcunov [this message]
2020-05-27 12:59   ` [Tarantool-patches] [PATCH v3 10/10] test: use direct log module Oleg Babin
2020-05-27 12:58 ` [Tarantool-patches] [PATCH v3 00/10] lua/log: add an ability to setup logger without box.cfg{} Oleg Babin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200527111406.145422-11-gorcunov@gmail.com \
    --to=gorcunov@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v3 10/10] test: use direct log module' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox