From: Igor Munkin <imun@tarantool.org>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] core: don't start example instance in postinstall
Date: Tue, 26 May 2020 19:00:38 +0300 [thread overview]
Message-ID: <20200526160037.GO5455@tarantool.org> (raw)
In-Reply-To: <76366f3a-19e4-f039-b84e-670e065d74a0@tarantool.org>
Olya,
Thanks, but I have last (but not least) nit: a ChangeLog entry need to
be plased aside from the commit message, i.e. under three dashes or in a
cover letter. Please adjust your commit message regarding this remark.
On 25.05.20, Olga Arkhangelskaia wrote:
> Hi Igor!
>
> Have fixed commit message:
>
> After tarantool installation on Debian/Ubuntu from repo, example instance
> was automatically started on 3301 port. At the same time example instance
> on RHEL/CentOS is started manually. Patch does the same for
> Debian/Ubuntu.
>
> Closes #4507
>
> @TarantoolBot document
> Title: manage example instance after installation
> After tarantool installation from repos on all distros example instance
> should be managed manually.
>
> @ChangeLog:
> * Do not start example instance on 3301 port after tarantool
> installation
> from Debian/Ubuntu repo.
>
<snipped>
--
Best regards,
IM
next prev parent reply other threads:[~2020-05-26 16:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 12:20 Olga Arkhangelskaia
2020-05-25 13:03 ` Igor Munkin
2020-05-25 16:27 ` Olga Arkhangelskaia
2020-05-26 15:09 ` Oleg Babin
2020-05-26 16:00 ` Igor Munkin [this message]
2020-05-27 10:04 ` Olga Arkhangelskaia
2020-05-27 16:02 ` Alexander Turenko
2020-05-28 9:28 ` Olga Arkhangelskaia
2020-05-28 11:33 ` Olga Arkhangelskaia
2020-06-04 21:51 ` Igor Munkin
2020-06-05 6:55 ` Alexander Turenko
2020-06-08 12:46 ` Yaroslav Dynnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526160037.GO5455@tarantool.org \
--to=imun@tarantool.org \
--cc=arkholga@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] core: don'\''t start example instance in postinstall' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox