From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Oleg Babin <olegrok@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>,
Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 00/10] lua/log: add an ability to setup logger without box.cfg{}
Date: Tue, 26 May 2020 17:00:36 +0300 [thread overview]
Message-ID: <20200526140036.GH2464@grain> (raw)
In-Reply-To: <f56f697b-6bb9-6ab6-222a-10ecd97fcc77@tarantool.org>
On Tue, May 26, 2020 at 04:42:52PM +0300, Oleg Babin wrote:
> Hi! Thanks for your changes.
>
> I have several comments:
...
>
> And seems I've missed this issue
> (https://github.com/tarantool/tarantool/issues/1054) when I asked about
> log.cfg. I think you could add "Closes #1054" as well.
Thanks! Will address in next series!
prev parent reply other threads:[~2020-05-26 14:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 12:46 Cyrill Gorcunov
2020-05-26 12:46 ` [Tarantool-patches] [PATCH v2 01/10] core/say: drop redundant declarations Cyrill Gorcunov
2020-05-26 12:46 ` [Tarantool-patches] [PATCH v2 02/10] core/say: drop vsay declaration Cyrill Gorcunov
2020-05-26 12:46 ` [Tarantool-patches] [PATCH v2 03/10] core/say: do not reconfig early set up logger Cyrill Gorcunov
2020-05-26 12:46 ` [Tarantool-patches] [PATCH v2 04/10] lua/log: declare say_logger_init and say_logger_initialized Cyrill Gorcunov
2020-05-26 12:46 ` [Tarantool-patches] [PATCH v2 05/10] lua/log: put string constants to map Cyrill Gorcunov
2020-05-26 12:46 ` [Tarantool-patches] [PATCH v2 06/10] lua/log: do not allow to set json for boot logger Cyrill Gorcunov
2020-05-26 12:46 ` [Tarantool-patches] [PATCH v2 07/10] lua/log: declare log as separate variable Cyrill Gorcunov
2020-05-26 12:46 ` [Tarantool-patches] [PATCH v2 08/10] lua/log: use log module settings inside box.cfg Cyrill Gorcunov
2020-05-26 12:46 ` [Tarantool-patches] [PATCH v2 09/10] lua/log: allow to configure logging without a box Cyrill Gorcunov
2020-05-26 12:46 ` [Tarantool-patches] [PATCH v2 10/10] test: use direct log module Cyrill Gorcunov
2020-05-26 13:42 ` [Tarantool-patches] [PATCH v2 00/10] lua/log: add an ability to setup logger without box.cfg{} Oleg Babin
2020-05-26 14:00 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526140036.GH2464@grain \
--to=gorcunov@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=olegrok@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 00/10] lua/log: add an ability to setup logger without box.cfg{}' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox