Re: [Tarantool-patches] [PATCH v2 2/2] wal: reorder tx rows so that a tx ends on a global row

[Konstantin Osipov <kostja.osipov@gmail.com>]

* Cyrill Gorcunov <gorcunov@gmail.com> [20/05/25 21:38]:
> On Mon, May 25, 2020 at 07:34:09PM +0300, Konstantin Osipov wrote:
> > * Serge Petrenko <sergepetrenko@tarantool.org> [20/05/25 14:00]:
> > 
> > While I think it's an acceptable strategy for a bugfix, I still
> > think relaying has to be fixed to be transactional, the current
> > xstream api is a huge legacy we're stuck with since Tarantool 1.3!
> > 
> > It saddens me a great deal the relay patch may be shuffled into
> > the desk once the problem is not as urgent.
> 
> Kostya, could you please describe xstream api here, so I would
> file a bug and will assign it to myself/someone and we won't
> forget. (yes, I remember you've said me about rework in f2f
> conversation but i might be missing some details so please
> write it here, in email)

The simplest change would be to switch from returning xrow * 
to returning xrow **, so that xstream can return an entire
transaction. Alternatively, applier is already using a stailq
of objects called applier_tx_row, these are nothing 
but stailq_entry object, this data structure could be reused in xsteam
api, so that it returns a stailq, similar to applier_read_tx.

-- 
Konstantin Osipov, Moscow, Russia