From: Igor Munkin <imun@tarantool.org>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] core: don't start example instance in postinstall
Date: Mon, 25 May 2020 16:03:29 +0300 [thread overview]
Message-ID: <20200525130329.GI5455@tarantool.org> (raw)
In-Reply-To: <20200429122038.53296-1-arkholga@tarantool.org>
Olya,
Thanks for the patch, LGTM except some nits regarding commit message.
However, it would be great to see a green full CI pipeline for such
changes especially Debian/Ubuntu packaging routines tests to confirm
nothing is broken after your change. Since this patch is trivial and
doesn't directly relate to package build process, I guess manual check
is enough.
On 29.04.20, Olga Arkhangelskaia wrote:
> After taratool installation on Debuan/Ubuntu from repo, example instance
Typo: s/taratool/tarantool/.
Typo: s/Debuan/Debian/.
> was automatically started over 3301 port. On the other hand example instance
Typo: s/over/on/.
Typo: s/On the other hand/At the same time/.
> on RHEL/CentOS is started manually. Patch does the same for Debian/Ubuntu.
>
> Closes #4507
>
> @TarantoolBot document
> Title: manage example instance after installation
> After tarantool installation from repos on all distros example instance
> should be managed manually.
> ---
Please provide a ChangeLog entry.
> Branch:
> https://github.com/tarantool/tarantool/tree/gh-4507-disable-start-example-instance
> debian/tarantool-common.postinst | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/debian/tarantool-common.postinst b/debian/tarantool-common.postinst
> index e2eda3415..03e4b2215 100644
> --- a/debian/tarantool-common.postinst
> +++ b/debian/tarantool-common.postinst
> @@ -22,14 +22,6 @@ case "$1" in
> install -d -o$SYSUSER -gadm -m2750 /var/log/tarantool
> install -d -o$SYSUSER -g$SYSUSER -m750 /var/run/tarantool
> install -d -o$SYSUSER -g$SYSUSER -m750 /var/lib/tarantool
> -
> - # Enable example.lua by default
> - if [ -z $2 ] && [ ! -e /etc/tarantool/instances.enabled/example.lua ] &&
> - [ -d /etc/tarantool/instances.enabled ] &&
> - [ -d /etc/tarantool/instances.available/ ]; then
> - ln -s /etc/tarantool/instances.available/example.lua \
> - /etc/tarantool/instances.enabled/example.lua
> - fi
> ;;
> esac
>
> --
> 2.20.1 (Apple Git-117)
>
--
Best regards,
IM
next prev parent reply other threads:[~2020-05-25 13:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 12:20 Olga Arkhangelskaia
2020-05-25 13:03 ` Igor Munkin [this message]
2020-05-25 16:27 ` Olga Arkhangelskaia
2020-05-26 15:09 ` Oleg Babin
2020-05-26 16:00 ` Igor Munkin
2020-05-27 10:04 ` Olga Arkhangelskaia
2020-05-27 16:02 ` Alexander Turenko
2020-05-28 9:28 ` Olga Arkhangelskaia
2020-05-28 11:33 ` Olga Arkhangelskaia
2020-06-04 21:51 ` Igor Munkin
2020-06-05 6:55 ` Alexander Turenko
2020-06-08 12:46 ` Yaroslav Dynnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525130329.GI5455@tarantool.org \
--to=imun@tarantool.org \
--cc=arkholga@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] core: don'\''t start example instance in postinstall' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox