From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/2] Copy DSO module before load instead of symlink-ing
Date: Sat, 23 May 2020 21:30:32 +0300 [thread overview]
Message-ID: <20200523183032.GB2714@atlas> (raw)
In-Reply-To: <0f65635ef9ee95131ac0e83b0b70e8c204a322b8.1589968157.git.kyukhin@tarantool.org>
* Kirill Yukhin <kyukhin@tarantool.org> [20/05/20 12:54]:
> + int ch;
> + while( ( ch = fgetc(source) ) != EOF )
> + fputc(ch, target);
This code looks like it is copied from stackoverflow?
For one, it does not follow Tarantool coding style.
and it's copying the file one byte at a time, good at least it's
in buffered mode?!
> + fclose(source);
> + fclose(target);
Please use libeio or, as last resort, sendfile().
Tarantool is a single threaded high-performance database and
application server. It's not OK to block the event loop for a few
hundred thousand instructions (and here we can easily get
millions).
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-05-23 18:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 9:51 [Tarantool-patches] [PATCH 0/2] Fix C module reloading Kirill Yukhin
2020-05-20 9:51 ` [Tarantool-patches] [PATCH 1/2] Copy DSO module before load instead of symlink-ing Kirill Yukhin
2020-05-23 18:30 ` Konstantin Osipov [this message]
2020-05-25 13:13 ` Kirill Yukhin
2020-05-25 14:34 ` Konstantin Osipov
2020-05-25 15:18 ` Cyrill Gorcunov
2020-05-25 15:26 ` Cyrill Gorcunov
2020-05-25 16:45 ` Konstantin Osipov
2020-05-25 18:38 ` Cyrill Gorcunov
2020-05-26 11:11 ` Kirill Yukhin
2020-05-26 15:16 ` Cyrill Gorcunov
2020-05-27 9:17 ` Kirill Yukhin
2020-05-27 10:49 ` Cyrill Gorcunov
2020-05-20 9:51 ` [Tarantool-patches] [PATCH 2/2] Allow to set directory for copying DSO before load Kirill Yukhin
2020-05-29 10:59 ` Cyrill Gorcunov
2020-06-01 10:53 ` Kirill Yukhin
2020-05-20 20:41 ` [Tarantool-patches] [PATCH 0/2] Fix C module reloading Nikita Pettik
2020-05-21 8:41 ` Kirill Yukhin
2020-06-01 10:52 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200523183032.GB2714@atlas \
--to=kostja.osipov@gmail.com \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/2] Copy DSO module before load instead of symlink-ing' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox