From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] lua: lua_field_inspect_table without pushcfunction
Date: Fri, 22 May 2020 17:05:30 +0300 [thread overview]
Message-ID: <20200522140530.ymb2wcory6tbi5sz@tkn_work_nb> (raw)
In-Reply-To: <20200518093748.16825-1-skaplun@tarantool.org>
On Mon, May 18, 2020 at 12:37:48PM +0300, Sergey Kaplun wrote:
> Currently on encoding table we push cfunction (lua_field_try_serialize)
> to lua stack with additional lightuserdata and table value and after
> pcall that function to avoid a raise of error.
It is often used to catch 'not enough memory' error. Say, to avoid a
leak if some resource should be freed before reporting an error. Or when
you want to return an error instead of raising it.
Please, look whether it was added by intention and verify that
everything still good after the patch.
next prev parent reply other threads:[~2020-05-22 14:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 9:37 Sergey Kaplun
2020-05-18 21:52 ` Vladislav Shpilevoy
2020-05-19 10:29 ` Sergey Kaplun
2020-05-19 20:08 ` Vladislav Shpilevoy
2020-05-22 11:48 ` Aleksandr Lyapunov
2020-05-22 14:05 ` Alexander Turenko [this message]
2020-05-25 12:06 ` Sergey Kaplun
2020-06-02 0:19 ` Igor Munkin
2020-06-02 9:36 ` Igor Munkin
2020-06-10 12:15 ` Kirill Yukhin
2020-06-10 13:01 ` Igor Munkin
2020-06-10 13:39 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522140530.ymb2wcory6tbi5sz@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=skaplun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] lua: lua_field_inspect_table without pushcfunction' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox