Tarantool development patches archive
 help / color / mirror / Atom feed
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: sergeyb@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] test: recover FreeBSD skip conditions
Date: Wed, 20 May 2020 19:48:42 +0300	[thread overview]
Message-ID: <20200520164842.GA3113@hpalx> (raw)
In-Reply-To: <44be366b7f79a73fa2d9c06f28a5551e58bbb860.1589991392.git.sergeyb@tarantool.org>

Hi Sergey, thanks for the patch, LGTM.

On Wed, May 20, 2020 at 07:16:58PM +0300, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> Due to inaccuracy FreeBSD skip conditions were overwritten by OpenBSD
> skip conditions.
> 
> Closes #5004
> ---
>  test/app/crypto.skipcond      |  4 ++++
>  test/app/digest.skipcond      |  4 ++++
>  test/app/socket.skipcond      | 30 +++++++++++++++++++++++++++---
>  test/box/net.box.skipcond     |  4 ++++
>  test/box/net_msg_max.skipcond |  4 ++++
>  5 files changed, 43 insertions(+), 3 deletions(-)
> 
> diff --git a/test/app/crypto.skipcond b/test/app/crypto.skipcond
> index 9c1ca22b1..108e776c4 100644
> --- a/test/app/crypto.skipcond
> +++ b/test/app/crypto.skipcond
> @@ -1,5 +1,9 @@
>  import platform
>  
> +# Disabled on FreeBSD due to flaky fail #4271.
> +if platform.system() == 'FreeBSD':
> +    self.skip = 1
> +
>  # Disabled on OpenBSD due to fail #XXXX.
>  if platform.system() == 'OpenBSD':
>      self.skip = 1
> diff --git a/test/app/digest.skipcond b/test/app/digest.skipcond
> index 9c1ca22b1..108e776c4 100644
> --- a/test/app/digest.skipcond
> +++ b/test/app/digest.skipcond
> @@ -1,5 +1,9 @@
>  import platform
>  
> +# Disabled on FreeBSD due to flaky fail #4271.
> +if platform.system() == 'FreeBSD':
> +    self.skip = 1
> +
>  # Disabled on OpenBSD due to fail #XXXX.
>  if platform.system() == 'OpenBSD':
>      self.skip = 1
> diff --git a/test/app/socket.skipcond b/test/app/socket.skipcond
> index 9c1ca22b1..a3748b093 100644
> --- a/test/app/socket.skipcond
> +++ b/test/app/socket.skipcond
> @@ -1,7 +1,31 @@
> +
> +# vim: set ft=python :
> +import re
> +import os.path
> +import socket
> +import os
> +import tempfile
>  import platform
>  
> -# Disabled on OpenBSD due to fail #XXXX.
> -if platform.system() == 'OpenBSD':
> +test_dir = tempfile.mkdtemp(prefix='tarantool-test-socket')
> +test_path = os.path.join(test_dir, 'socket')
> +
> +s = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
> +try:
> +    s.bind(test_path)
> +except:
>      self.skip = 1
>  
> -# vim: set ft=python:
> +s.close()
> +
> +if os.path.exists(test_path):
> +    os.remove(test_path)
> +    os.rmdir(test_dir)
> +
> +# Disabled on FreeBSD due to flaky fail #4271.
> +if platform.system() == 'FreeBSD':
> +    self.skip = 1
> +
> +# Disabled on OpenBSD due to fail #XXX.
> +if platform.system() == 'OpenBSD':
> +    self.skip = 1
> diff --git a/test/box/net.box.skipcond b/test/box/net.box.skipcond
> index 9c1ca22b1..58b83f415 100644
> --- a/test/box/net.box.skipcond
> +++ b/test/box/net.box.skipcond
> @@ -4,4 +4,8 @@ import platform
>  if platform.system() == 'OpenBSD':
>      self.skip = 1
>  
> +# Disabled on FreeBSD due to flaky fail #4271.
> +if platform.system() == 'FreeBSD':
> +    self.skip = 1
> +
>  # vim: set ft=python:
> diff --git a/test/box/net_msg_max.skipcond b/test/box/net_msg_max.skipcond
> index 9c1ca22b1..58b83f415 100644
> --- a/test/box/net_msg_max.skipcond
> +++ b/test/box/net_msg_max.skipcond
> @@ -4,4 +4,8 @@ import platform
>  if platform.system() == 'OpenBSD':
>      self.skip = 1
>  
> +# Disabled on FreeBSD due to flaky fail #4271.
> +if platform.system() == 'FreeBSD':
> +    self.skip = 1
> +
>  # vim: set ft=python:
> -- 
> 2.23.0
> 

  reply	other threads:[~2020-05-20 16:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20 16:16 sergeyb
2020-05-20 16:48 ` Alexander V. Tikhonov [this message]
2020-05-22 13:04 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200520164842.GA3113@hpalx \
    --to=avtikhon@tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] test: recover FreeBSD skip conditions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox