From: Sergey Bronnikov <sergeyb@tarantool.org>
To: Oleg Piskunov <o.piskunov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1] gitlab-ci: cleanup temporary perf images
Date: Wed, 20 May 2020 11:30:23 +0300 [thread overview]
Message-ID: <20200520083023.GC1400@pony.bronevichok.ru> (raw)
In-Reply-To: <1589934997.349902287@f427.i.mail.ru>
Hi, Oleg!
generally LGTM, but see my question regarding commit message.
On 03:36 Wed 20 May , Oleg Piskunov wrote:
>
>
> - add cleanup after perf docker
> image preparation (perf_bootstrap job).
> - cleanup perf docker images on execution hosts
> after perf testing (cleanup stage).
>
> Closes #5003
There is a best practice to explain 'what' and 'why' in a commit message
body. It is unclear why we should cleanup these images and cannot reuse
existed images.
<snipped>
next prev parent reply other threads:[~2020-05-20 8:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 0:36 Oleg Piskunov
2020-05-20 8:30 ` Sergey Bronnikov [this message]
2020-05-21 7:09 ` Oleg Piskunov
2020-05-20 16:44 ` Alexander V. Tikhonov
2020-05-21 7:53 ` Oleg Piskunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520083023.GC1400@pony.bronevichok.ru \
--to=sergeyb@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=o.piskunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] gitlab-ci: cleanup temporary perf images' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox