Re: [Tarantool-patches] [PATCH v2] Add option to update file with reference output

[Sergey Bronnikov <sergeyb@tarantool.org>]

Hi, Alexander

On 11:03 Wed 20 May , Alexander V. Tikhonov wrote:
> Hi Sergey, thanks for the patch. In general LGTM, but want to ask if
> it is needed to mention in help message of the new --update-result
> option that the new result file will be in the new result style, I
> mean the following difference, please check:
>   mv replication/misc.result replication/misc.saved
>   ./test-run.py replication/misc.test.lua --update-result
>   diff replication/misc.result replication/misc.saved

Thanks for review! I suppose it's not a problem when we will have an option
to update .result files.

> On Tue, May 19, 2020 at 01:25:46PM +0300, sergeyb@tarantool.org wrote:
> > From: Sergey Bronnikov <sergeyb@tarantool.org>
> > 
> > New option covers two cases:
> > - in case of test failure test-run.py create a file .reject with
> > actual test output and one need to move .reject file to .result manually
> > when test has a valid behaviour. With option --update-result test-run.py
> > will do it automatically.
> > - in case of abcense reference result file test-run.py forced to create
> > such file in a source directory and set test status "new". This patch
> > changes behaviour. With option --update-result test status is "new"
> > and result file is created, without option test status is "fail" and
> > result file is not created.
> > 
> > Fixes https://github.com/tarantool/tarantool/issues/4654
> > Fixes https://github.com/tarantool/tarantool/issues/4258
> > Closes #194

<snipped>