From: Alexander Turenko <alexander.turenko@tarantool.org> To: "Alexander V. Tikhonov" <avtikhon@tarantool.org> Cc: Oleg Piskunov <o.piskunov@tarantool.org>, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v4 3/3] test: add more tests to packaging testing Date: Wed, 20 May 2020 01:14:56 +0300 [thread overview] Message-ID: <20200519221456.oi5pko5gbl5bp4g3@tkn_work_nb> (raw) In-Reply-To: <f1458f782f7a7949a1434871d1415e6048904be9.1589861898.git.avtikhon@tarantool.org> On Tue, May 19, 2020 at 07:30:36AM +0300, Alexander V. Tikhonov wrote: > Changed number of tests to packaging testing jobs from > suites: "unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/", > to all suites except 'replication/' suite which has special > issue for it's enabling: > https://github.com/tarantool/tarantool/issues/4798 > Also added testing to the all available packing jobs except > 'CentOS 6'. > > Removed test-run option that run testing inline to be > able to run it in parallel. Also changed 'test-run' to Nit: I would say 'test-run.py --force' to 'make test-force', because when I read the comment I did think that it was w/o --force before. > 'make test-force' command. Nit: I would add a few words why Travis CI and GitLab CI testing differs from each other. It is not obvious. > > Closes #4599 > --- > rpm/tarantool.spec | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/rpm/tarantool.spec b/rpm/tarantool.spec > index e15de3c12..88b1d6b5c 100644 > --- a/rpm/tarantool.spec > +++ b/rpm/tarantool.spec > @@ -163,9 +163,19 @@ make %{?_smp_mflags} > rm -rf %{buildroot}%{_datarootdir}/doc/tarantool/ > > %check > +%if "%{_ci}" == "travis" > %if (0%{?fedora} >= 22 || 0%{?rhel} >= 7) > cd test && ./test-run.py --force -j 1 unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/ > %endif > +%else > +%if 0%{?rhel} != 6 > +# Run all available test suites except 'replication' > +# which is not currently ready for this testing and > +# has standalone issue for it's enabling: > +# https://github.com/tarantool/tarantool/issues/4798 > +TEST_RUN_EXCLUDE='replication/' make test-force > +%endif > +%endif Nit: No need to keep `0%{?fedora} >= 22` condition anymore, you removed it for dependencies in the first commit. So I would change it in the first commit in sync with the change for deps: | %if 0%{?rhel} != 6 | cd test && <...> | %endif And then change here (3rd commit) again to split travis-ci / gitlab-ci testing: | %if 0%{?rhel} != 6 | %if "%{_ci}" == "travis" | cd test && <...> | %else | # Comment. | TEST_RUN_EXCLUDE='replication/' make test-force | %endif | %endif
next prev parent reply other threads:[~2020-05-19 22:15 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-19 4:30 [Tarantool-patches] [PATCH v4 0/3] " Alexander V. Tikhonov 2020-05-19 4:30 ` [Tarantool-patches] [PATCH v4 1/3] build: fix rpm packages build on Fedora 32 Alexander V. Tikhonov 2020-05-19 4:30 ` [Tarantool-patches] [PATCH v4 2/3] test: return tests to packaging testing Alexander V. Tikhonov 2020-05-19 4:30 ` [Tarantool-patches] [PATCH v4 3/3] test: add more " Alexander V. Tikhonov 2020-05-19 22:14 ` Alexander Turenko [this message] 2020-05-19 22:18 ` [Tarantool-patches] [PATCH v4 0/3] " Alexander Turenko 2020-05-20 6:59 ` Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200519221456.oi5pko5gbl5bp4g3@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=avtikhon@tarantool.org \ --cc=o.piskunov@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v4 3/3] test: add more tests to packaging testing' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox