From: Nikita Pettik <korablev@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>,
Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 5/5] box/vynil: quota -- fix compilation waning
Date: Tue, 19 May 2020 12:33:48 +0000 [thread overview]
Message-ID: <20200519123348.GA12739@tarantool.org> (raw)
In-Reply-To: <20200518101502.117121-6-gorcunov@gmail.com>
On 18 May 13:15, Cyrill Gorcunov wrote:
> There is a mixture of types and clang prefer
> explicit conversion (since @value is a double).
LGTM as obvious.
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
> src/box/vy_quota.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/box/vy_quota.h b/src/box/vy_quota.h
> index 63d4f6a81..bd7d4e03d 100644
> --- a/src/box/vy_quota.h
> +++ b/src/box/vy_quota.h
> @@ -104,7 +104,7 @@ vy_rate_limit_refill(struct vy_rate_limit *rl, double time)
> double value = rl->value + size;
> /* Allow bursts up to 2x rate. */
> value = MIN(value, size * 2);
> - rl->value = MIN(value, SSIZE_MAX);
> + rl->value = MIN((ssize_t)value, SSIZE_MAX);
> }
>
> typedef void
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-05-19 12:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 10:14 [Tarantool-patches] [PATCH 0/5] build: fix compilation warning Cyrill Gorcunov
2020-05-18 10:14 ` [Tarantool-patches] [PATCH 1/5] test: unit/guava -- " Cyrill Gorcunov
2020-05-18 10:14 ` [Tarantool-patches] [PATCH 2/5] box/sql: func " Cyrill Gorcunov
2020-05-18 11:13 ` Mergen Imeev
2020-05-18 11:32 ` Cyrill Gorcunov
2020-05-18 10:15 ` [Tarantool-patches] [PATCH 3/5] box/sql: vdbe " Cyrill Gorcunov
2020-05-18 10:15 ` [Tarantool-patches] [PATCH 4/5] box/sql: vdbemem " Cyrill Gorcunov
2020-05-18 10:15 ` [Tarantool-patches] [PATCH 5/5] box/vynil: quota -- fix compilation waning Cyrill Gorcunov
2020-05-19 12:33 ` Nikita Pettik [this message]
2020-10-01 12:07 ` [Tarantool-patches] [PATCH 0/5] build: fix compilation warning Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519123348.GA12739@tarantool.org \
--to=korablev@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 5/5] box/vynil: quota -- fix compilation waning' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox