From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 5/5] msgpuck: activate MP_EXT custom serializers
Date: Tue, 19 May 2020 15:11:48 +0300 [thread overview]
Message-ID: <20200519121148.v4fiwv65by3tbpc2@tkn_work_nb> (raw)
In-Reply-To: <a52f0854-6130-349f-868c-d1297e3a8df8@tarantool.org>
> diff --git a/src/box/msgpack.c b/src/box/msgpack.c
> index 37bb3920c..4013aec4c 100644
> --- a/src/box/msgpack.c
> +++ b/src/box/msgpack.c
> @@ -49,7 +49,8 @@ msgpack_fprint_ext(FILE *file, const char **data, int depth)
> case MP_ERROR:
> return mp_fprint_error(file, data, depth);
> default:
> - return fprintf(file, "undefined");
> + return fprintf(file, "(extension: type %d, len %u)", (int)type,
> + (unsigned)len);
> }
> }
I would reuse mp_fprint_ext_default() here.
>
> @@ -66,7 +67,8 @@ msgpack_snprint_ext(char *buf, int size, const char **data, int depth)
> case MP_ERROR:
> return mp_snprint_error(buf, size, data, depth);
> default:
> - return snprintf(buf, size, "undefined");
> + return snprintf(buf, size, "(extension: type %d, len %u)",
> + (int)type, (unsigned)len);
> }
> }
Same.
next prev parent reply other threads:[~2020-05-19 12:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 23:45 [Tarantool-patches] [PATCH 0/5] mp_snprint() and mp_fprint() for decimal, uuid, error Vladislav Shpilevoy
2020-05-11 23:45 ` [Tarantool-patches] [PATCH 1/5] msgpuck: bump version to enable extension printer Vladislav Shpilevoy
2020-05-12 17:34 ` Cyrill Gorcunov
2020-05-11 23:45 ` [Tarantool-patches] [PATCH 2/5] decimal: provide MP_DECIMAL extension serializer Vladislav Shpilevoy
2020-05-12 15:13 ` Cyrill Gorcunov
2020-05-12 20:30 ` Vladislav Shpilevoy
2020-05-12 20:56 ` Cyrill Gorcunov
2020-05-12 17:35 ` Cyrill Gorcunov
2020-05-11 23:45 ` [Tarantool-patches] [PATCH 3/5] uuid: provide MP_UUID " Vladislav Shpilevoy
2020-05-12 17:36 ` Cyrill Gorcunov
2020-05-11 23:45 ` [Tarantool-patches] [PATCH 4/5] error: provide MP_ERROR " Vladislav Shpilevoy
2020-05-12 17:52 ` Cyrill Gorcunov
2020-05-12 20:38 ` Vladislav Shpilevoy
2020-05-12 21:27 ` Cyrill Gorcunov
2020-05-18 15:24 ` Serge Petrenko
2020-05-13 12:31 ` Nikita Pettik
2020-05-13 22:10 ` Vladislav Shpilevoy
2020-05-14 2:32 ` Nikita Pettik
2020-05-14 21:28 ` Vladislav Shpilevoy
2020-05-19 13:21 ` Nikita Pettik
2020-05-20 21:57 ` Vladislav Shpilevoy
2020-05-19 11:51 ` Alexander Turenko
2020-05-19 20:48 ` Vladislav Shpilevoy
2020-05-11 23:45 ` [Tarantool-patches] [PATCH 5/5] msgpuck: activate MP_EXT custom serializers Vladislav Shpilevoy
2020-05-12 17:52 ` Cyrill Gorcunov
2020-05-13 21:06 ` Nikita Pettik
2020-05-13 21:48 ` Vladislav Shpilevoy
2020-05-14 2:24 ` Nikita Pettik
2020-05-14 21:27 ` Vladislav Shpilevoy
2020-05-19 12:11 ` Alexander Turenko [this message]
2020-05-19 20:48 ` Vladislav Shpilevoy
2020-05-19 13:23 ` Nikita Pettik
2020-05-18 15:25 ` [Tarantool-patches] [PATCH 0/5] mp_snprint() and mp_fprint() for decimal, uuid, error Serge Petrenko
2020-05-21 18:25 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519121148.v4fiwv65by3tbpc2@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 5/5] msgpuck: activate MP_EXT custom serializers' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox