Re: [Tarantool-patches] [PATCH 1/1] session: remove box.session.push() 'sync'

[Kirill Yukhin <kyukhin@tarantool.org>]

Hello,

On 04 май 23:42, Vladislav Shpilevoy wrote:
> Closes #4689
> 
> @TarantoolBot document
> Title: box.session.push() 'sync' is deprecated
> 
> box.session.push() had two parameters - data to push and 'sync'.
> The sync was a request ID with which the out of bound data should
> be pushed into a socket.
> 
> This was introduced as a workaround for #3450, and is useless
> since its resolution.
> 
> A user anyway can't push to different sessions, where that
> parameter could be useful. And pushing into requests of the same
> session, on the contrary, is something not really needed anywhere,
> not portable to non-binary session types (console, background),
> and is just dangerous since it is easy to add a bug here.
> 
> The patch removes the parameter. Now there will be thrown a
> 'Usage' error at attempt to use 'sync' parameter. In version 2.4
> it is deprecated, prints warnings into logs, but still works. In
> 2.5 it is removed completely.

I've checked your patch into master.

--
Regards, Kirill Yukhin