From: Igor Munkin <imun@tarantool.org>
To: Oleg Babin <olegrok@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 4/7] box/console: rename luaL_yaml_default to serializer_yaml
Date: Tue, 19 May 2020 00:17:36 +0300 [thread overview]
Message-ID: <20200518211736.GF5455@tarantool.org> (raw)
In-Reply-To: <6c634b97-e9bd-c2eb-0916-c303cd2ccadf@tarantool.org>
Oleg,
On 18.05.20, Oleg Babin wrote:
> Hi! I'm not sure that we really should do that. Functions with LuaL
> prefix is a part of Lua code convention AFAIK.
> (https://www.lua.org/manual/5.1/manual.html#4)
No, it doesn't relate to Lua code convention (at least to the one you've
mentioned). luaL_ is just a custom prefix for functions declared/defined
in lauxlib.h header, which is a part of Lua public API.
| All functions from the auxiliary library are defined in header file
| lauxlib.h and have a prefix luaL_.
However this prefix is also used for auxiliary functions provided by
Tarantool (e.g luaL_pushcdata). This *might* be an argument for
convention saving but it's definitely a weak one for these changes. I
see no problems with the renaming Cyrill made within this patch, since
it just affects the name of the static global variable. Please also
consider the issue[1] that closely relates to the subj.
>
<snipped>
[1]: https://github.com/tarantool/tarantool/issues/4577
--
Best regards,
IM
next prev parent reply other threads:[~2020-05-18 21:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 13:50 [Tarantool-patches] [PATCH 0/7] box/console: add support for internal types Cyrill Gorcunov
2020-05-12 13:50 ` [Tarantool-patches] [PATCH 1/7] box/console: console_session_vtab -- use designated initialization Cyrill Gorcunov
2020-05-18 12:03 ` Oleg Babin
2020-05-12 13:50 ` [Tarantool-patches] [PATCH 2/7] box/console: use tabs instead of spaces in consolelib Cyrill Gorcunov
2020-05-18 12:04 ` Oleg Babin
2020-05-12 13:50 ` [Tarantool-patches] [PATCH 3/7] box/console: rename format to format_yaml Cyrill Gorcunov
2020-05-18 12:04 ` Oleg Babin
2020-05-12 13:50 ` [Tarantool-patches] [PATCH 4/7] box/console: rename luaL_yaml_default to serializer_yaml Cyrill Gorcunov
2020-05-18 12:11 ` Oleg Babin
2020-05-18 21:17 ` Igor Munkin [this message]
2020-05-19 6:47 ` Oleg Babin
2020-05-12 13:50 ` [Tarantool-patches] [PATCH 5/7] box/console: implement lua serializer Cyrill Gorcunov
2020-05-18 12:18 ` Oleg Babin
2020-05-12 13:50 ` [Tarantool-patches] [PATCH 6/7] box/console: switch to new " Cyrill Gorcunov
2020-05-18 12:21 ` Oleg Babin
2020-05-12 13:50 ` [Tarantool-patches] [PATCH 7/7] test: extend console lua test Cyrill Gorcunov
2020-05-18 12:22 ` Oleg Babin
2020-05-18 12:25 ` Cyrill Gorcunov
2020-05-18 12:46 ` [Tarantool-patches] [PATCH 0/7] box/console: add support for internal types Kirill Yukhin
-- strict thread matches above, loose matches on Subject: below --
2020-05-08 11:47 Cyrill Gorcunov
2020-05-08 11:47 ` [Tarantool-patches] [PATCH 4/7] box/console: rename luaL_yaml_default to serializer_yaml Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518211736.GF5455@tarantool.org \
--to=imun@tarantool.org \
--cc=olegrok@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 4/7] box/console: rename luaL_yaml_default to serializer_yaml' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox