Re: [Tarantool-patches] [PATCH 0/7] box/console: add support for internal types

[Kirill Yukhin <kyukhin@tarantool.org>]

Hello,

On 12 май 16:50, Cyrill Gorcunov wrote:
> In the series we implement support for internal taranool types
> such as ULL. To be able to do so we implement own serializer
> thus the output is simiar to encodings in yaml mode.
> 
> Once things settle down we will drop serpent module. I guess
> I need to explain why serpent didn't fit: there is no interface
> inside serpent to fetch internal tarantool types and adding it
> means more work to do than implement an own serializer.
> 
> v-2:
>  - address issues with achors encoding
> 
> issue https://github.com/tarantool/tarantool/issues/4682
> branch gorcunov/gh-4682-console-numbers-2
> 
> Cyrill Gorcunov (7):
>   box/console: console_session_vtab -- use designated initialization
>   box/console: use tabs instead of spaces in consolelib
>   box/console: rename format to format_yaml
>   box/console: rename luaL_yaml_default to serializer_yaml
>   box/console: implement lua serializer
>   box/console: switch to new lua serializer
>   test: extend console lua test

LGTM.

I've checked your patch into 2.4 and master.
I didn't committed it further. Maybe will do that in future.

--
Regards, Kirill Yukhin