From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Mergen Imeev <imeevma@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>,
Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 2/5] box/sql: func -- fix compilation warning
Date: Mon, 18 May 2020 14:32:09 +0300 [thread overview]
Message-ID: <20200518113209.GA2194@grain> (raw)
In-Reply-To: <20200518111306.GA12861@tarantool.org>
On Mon, May 18, 2020 at 02:13:07PM +0300, Mergen Imeev wrote:
> > @@ -845,9 +845,9 @@ roundFunc(sql_context * context, int argc, sql_value ** argv)
> > * handle the rounding directly,
> > * otherwise use printf.
> > */
> > - if (n == 0 && r >= 0 && r < LARGEST_INT64 - 1) {
> > + if (n == 0 && r >= 0 && r < (double)(LARGEST_INT64 - 1)) {
> > r = (double)((sql_int64) (r + 0.5));
> I am not sure that this change worth to do since
> LARGEST_INT64 = 2^63 -1 and
> (double)(LARGEST_INT64 - 1) == 2^63, if I am not wrong.
> I also not sure that this worked right before.
> I think it makes sense to compare with someting like 2^53,
> because if absolute value of r is greater that 2^53 than
> we do not have to round it anymore.
Mergen, I've no clue which limits we have in sql, thus it
is up to you. Either fix it on top either provide a patch
instead please.
next prev parent reply other threads:[~2020-05-18 11:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 10:14 [Tarantool-patches] [PATCH 0/5] build: " Cyrill Gorcunov
2020-05-18 10:14 ` [Tarantool-patches] [PATCH 1/5] test: unit/guava -- " Cyrill Gorcunov
2020-05-18 10:14 ` [Tarantool-patches] [PATCH 2/5] box/sql: func " Cyrill Gorcunov
2020-05-18 11:13 ` Mergen Imeev
2020-05-18 11:32 ` Cyrill Gorcunov [this message]
2020-05-18 10:15 ` [Tarantool-patches] [PATCH 3/5] box/sql: vdbe " Cyrill Gorcunov
2020-05-18 10:15 ` [Tarantool-patches] [PATCH 4/5] box/sql: vdbemem " Cyrill Gorcunov
2020-05-18 10:15 ` [Tarantool-patches] [PATCH 5/5] box/vynil: quota -- fix compilation waning Cyrill Gorcunov
2020-05-19 12:33 ` Nikita Pettik
2020-10-01 12:07 ` [Tarantool-patches] [PATCH 0/5] build: fix compilation warning Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518113209.GA2194@grain \
--to=gorcunov@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/5] box/sql: func -- fix compilation warning' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox