From: Kirill Yukhin <kyukhin@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] session: deprecate box.session.push() 'sync'
Date: Mon, 18 May 2020 11:45:06 +0300 [thread overview]
Message-ID: <20200518084506.xjj5yfxnkl6duqsf@tarantool.org> (raw)
In-Reply-To: <bd0c7652edec1fa695303ab06953556f2c86fe09.1588628598.git.v.shpilevoy@tarantool.org>
Hello,
On 04 май 23:43, Vladislav Shpilevoy wrote:
> box.session.push() has two parameters - data to push and 'sync'.
> The sync is a request ID with which the out of bound data should
> be pushed into a socket.
>
> This was introduced as a workaround for #3450, and is useless
> since its resolution.
>
> A user anyway can't push to different sessions, where that
> parameter could be useful. And pushing into requests of the same
> session, on the contrary, is something not really needed anywhere,
> not portable to non-binary session types (console, background),
> and is just dangerous since it is easy to add a bug here.
>
> The patch makes the parameter deprecated. Now on its usage there
> will be a rate limited warning in the logs.
>
> Part of #4689
I've checked your patch into 2.4.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-05-18 8:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 21:43 Vladislav Shpilevoy
2020-05-18 8:45 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518084506.xjj5yfxnkl6duqsf@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] session: deprecate box.session.push() '\''sync'\''' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox