Tarantool development patches archive
 help / color / mirror / Atom feed
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Oleg Piskunov <o.piskunov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2] gitlab-ci: parallelize perf testing
Date: Sun, 17 May 2020 15:34:35 +0300	[thread overview]
Message-ID: <20200517123435.GB17304@hpalx> (raw)
In-Reply-To: <1589612182.887817168@f503.i.mail.ru>

Hi Oleg, thanks for the patch. LGTM.

On Sat, May 16, 2020 at 09:56:22AM +0300, Oleg Piskunov wrote:
> 
>  
> - Adding 2 servers (sh1, sh2) for performance testing.
> - Rebalance performance testing between servers:
>   - sh1 (tag: docker_sh1_perf) used for benches:
>     nosqlbench_hash, nosqlbench_tree
>   - sh2 (tag: docker_sh2_perf) used for benches:
>     ycsb_hash, ycsb_tree, cbench
>   - sh3 (tag: docker_sh3_perf) used for benches:
>     sysbench, tpcc
>   - sh9 (tag: docker_perf_ssd) used for benches:
>     linkbench_ssd
> - Changing gitlab-ci tag for performance docker images
>   from 'perf' to 'deploy'.
>  
> Closes #4868
> ---
>  
> Github:  https://github.com/tarantool/tarantool/tree/opiskunov/gh-4868-parallel-perf
> Issue:  https://github.com/tarantool/tarantool/issues/4868
> 
>  .gitlab-ci.yml | 18 +++++++++++++++---
>  1 file changed, 15 insertions(+), 3 deletions(-)
>  
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index c7f58b9..fc214ef 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -91,8 +91,6 @@ variables:
>    <<: *perf_only_definition
>    image: ${IMAGE_PERF_BUILT}
>    stage: perf
> -  tags:
> -    - docker_perf
>    artifacts:
>      when: always
>      paths:
> @@ -191,7 +189,7 @@ perf_bootstrap:
>    <<: *perf_only_definition
>    stage: test
>    tags:
> -    - perf
> +    - deploy
>    script:
>      - ${GITLAB_MAKE} perf_prepare
>  
> @@ -199,18 +197,24 @@ perf_bootstrap:
>  
>  perf_sysbench:
>    <<: *perf_docker_test_definition
> +  tags:
> +    - docker_sh3_perf
>    variables:
>      <<: *perf_vars_definition
>      BENCH: 'sysbench'
>  
>  perf_tpcc:
>    <<: *perf_docker_test_definition
> +  tags:
> +    - docker_sh3_perf
>    variables:
>      <<: *perf_vars_definition
>      BENCH: 'tpcc'
>  
>  perf_ycsb_hash:
>    <<: *perf_docker_test_definition
> +  tags:
> +    - docker_sh2_perf
>    variables:
>      <<: *perf_vars_definition
>      BENCH: 'ycsb'
> @@ -218,6 +222,8 @@ perf_ycsb_hash:
>  
>  perf_ycsb_tree:
>    <<: *perf_docker_test_definition
> +  tags:
> +    - docker_sh2_perf
>    variables:
>      <<: *perf_vars_definition
>      BENCH: 'ycsb'
> @@ -225,6 +231,8 @@ perf_ycsb_tree:
>  
>  perf_nosqlbench_hash:
>    <<: *perf_docker_test_definition
> +  tags:
> +    - docker_sh1_perf
>    variables:
>      <<: *perf_vars_definition
>      BENCH: 'nosqlbench'
> @@ -232,6 +240,8 @@ perf_nosqlbench_hash:
>  
>  perf_nosqlbench_tree:
>    <<: *perf_docker_test_definition
> +  tags:
> +    - docker_sh1_perf
>    variables:
>      <<: *perf_vars_definition
>      BENCH: 'nosqlbench'
> @@ -239,6 +249,8 @@ perf_nosqlbench_tree:
>  
>  perf_cbench:
>    <<: *perf_docker_test_definition
> +  tags:
> +    - docker_sh2_perf
>    variables:
>      <<: *perf_vars_definition
>      BENCH: 'cbench'
> --
> 1.8.3.1
>  

  reply	other threads:[~2020-05-17 12:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-16  6:56 Oleg Piskunov
2020-05-17 12:34 ` Alexander V. Tikhonov [this message]
2020-05-18  9:14 ` Sergey Bronnikov
2020-05-28  7:40 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200517123435.GB17304@hpalx \
    --to=avtikhon@tarantool.org \
    --cc=o.piskunov@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2] gitlab-ci: parallelize perf testing' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox