Re: [Tarantool-patches] [PATCH 1/1] test: make app-tap/init_script produce less diff

[Kirill Yukhin <kyukhin@tarantool.org>]

Hello,

On 01 май 20:45, Vladislav Shpilevoy wrote:
> When a new option is added, app-tap/init_script
> outputs big diff. Because all options are printed with
> ordinal indexes. Addition of a new option changes
> indexes of all options after the new one.
> 
> The patch removes indexes from the output making diff
> smaller, when a new option is added.
> ---
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/app-tap/init_script-test-diff
> 
> The patch is motivated by forthcoming option
> replication_sync_quorum. When I added, it produced diff about 25
> lines in this test. After the patch it becomes 1.
> 
>  test/app-tap/init_script.result   | 96 +++++++++++++++----------------
>  test/app-tap/init_script.test.lua |  2 +-
>  2 files changed, 49 insertions(+), 49 deletions(-)

LGTM.

I've checked your patch into 1.10, 2.3, 2.4 and master.

--
Regards, Kirill Yukhin