Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov <sergeyb@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: Oleg Piskunov <o.piskunov@tarantool.org>,
	tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1] gitlab-ci: disable perf tesing in schedulled runs
Date: Thu, 14 May 2020 13:43:29 +0300	[thread overview]
Message-ID: <20200514104329.GB22063@pony.bronevichok.ru> (raw)
In-Reply-To: <2ad8677044f4a2eac3ec7ae3479dbebe09ea3f15.1589452096.git.avtikhon@tarantool.org>

Alexander, thanks for the patch.
Please fix typo in commit message: schedulled -> scheduled.

LGTM

On 13:29 Thu 14 May , Alexander V. Tikhonov wrote:
> Release branches should be regularly run using gitlab-ci pipeline
> schedules:
>   https://gitlab.com/tarantool/tarantool/pipeline_schedules
> It will help to detect flaky issues. But there is no need to rerun
> too long running performance testing, to block it in schedules the
> option 'schedules' in 'except:' field was set.
> 
> Part of #4974
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/schedule_except_perf
> Issue: https://github.com/tarantool/tarantool/issues/4974
> 
>  .gitlab-ci.yml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index c7f58b98d..256b368c4 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -32,6 +32,8 @@ variables:
>    only:
>      - master
>      - /^.*-perf$/
> +  except:
> +    - schedules
>    variables: &perf_vars_definition
>      IMAGE_PERF: "${CI_REGISTRY}/${CI_PROJECT_PATH}/perf/ubuntu-bionic:perf_master"
>      IMAGE_PERF_BUILT: "${CI_REGISTRY}/${CI_PROJECT_PATH}/perf_tmp/ubuntu-bionic:perf_${CI_COMMIT_SHORT_SHA}"
> -- 
> 2.17.1

  reply	other threads:[~2020-05-14 10:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 10:29 Alexander V. Tikhonov
2020-05-14 10:43 ` Sergey Bronnikov [this message]
2020-05-14 12:03 ` Oleg Piskunov
2020-05-15 14:51 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200514104329.GB22063@pony.bronevichok.ru \
    --to=sergeyb@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=o.piskunov@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1] gitlab-ci: disable perf tesing in schedulled runs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox