From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 4/5] error: provide MP_ERROR extension serializer
Date: Wed, 13 May 2020 00:27:24 +0300 [thread overview]
Message-ID: <20200512212724.GI2219@grain> (raw)
In-Reply-To: <6c8dc667-43ce-997b-1b1f-cf725f05a2f8@tarantool.org>
On Tue, May 12, 2020 at 10:38:25PM +0200, Vladislav Shpilevoy wrote:
...
> >
> > Don't get it -- include current file?! This a good sign of
> > some kind of problem in the code structure... If we need
> > a template then it should be some .cc/.c file explicily
> > included instead of __FILE__, no?
>
> I don't want to introduce a new file just for these 2 functions
> (mp_fprint_error() and mp_snprint_error()). This would be even
> worse than it is now. So I used the same file. I wrote __FILE__
> instead of mp_error.cc, so as to minimize diff, when mp_error.cc
> will be converted to C and moved to lib/core (that is planned).
> Also #include __FILE__ is more clear, when you want to say
> "include self", IMO.
OK, thanks for the long explanation, Vlad! I trimmed the mail
to not overquote. As to alignments and the rest -- up to you
(hopefully Sergey and Nikita will take look as well).
next prev parent reply other threads:[~2020-05-12 21:27 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 23:45 [Tarantool-patches] [PATCH 0/5] mp_snprint() and mp_fprint() for decimal, uuid, error Vladislav Shpilevoy
2020-05-11 23:45 ` [Tarantool-patches] [PATCH 1/5] msgpuck: bump version to enable extension printer Vladislav Shpilevoy
2020-05-12 17:34 ` Cyrill Gorcunov
2020-05-11 23:45 ` [Tarantool-patches] [PATCH 2/5] decimal: provide MP_DECIMAL extension serializer Vladislav Shpilevoy
2020-05-12 15:13 ` Cyrill Gorcunov
2020-05-12 20:30 ` Vladislav Shpilevoy
2020-05-12 20:56 ` Cyrill Gorcunov
2020-05-12 17:35 ` Cyrill Gorcunov
2020-05-11 23:45 ` [Tarantool-patches] [PATCH 3/5] uuid: provide MP_UUID " Vladislav Shpilevoy
2020-05-12 17:36 ` Cyrill Gorcunov
2020-05-11 23:45 ` [Tarantool-patches] [PATCH 4/5] error: provide MP_ERROR " Vladislav Shpilevoy
2020-05-12 17:52 ` Cyrill Gorcunov
2020-05-12 20:38 ` Vladislav Shpilevoy
2020-05-12 21:27 ` Cyrill Gorcunov [this message]
2020-05-18 15:24 ` Serge Petrenko
2020-05-13 12:31 ` Nikita Pettik
2020-05-13 22:10 ` Vladislav Shpilevoy
2020-05-14 2:32 ` Nikita Pettik
2020-05-14 21:28 ` Vladislav Shpilevoy
2020-05-19 13:21 ` Nikita Pettik
2020-05-20 21:57 ` Vladislav Shpilevoy
2020-05-19 11:51 ` Alexander Turenko
2020-05-19 20:48 ` Vladislav Shpilevoy
2020-05-11 23:45 ` [Tarantool-patches] [PATCH 5/5] msgpuck: activate MP_EXT custom serializers Vladislav Shpilevoy
2020-05-12 17:52 ` Cyrill Gorcunov
2020-05-13 21:06 ` Nikita Pettik
2020-05-13 21:48 ` Vladislav Shpilevoy
2020-05-14 2:24 ` Nikita Pettik
2020-05-14 21:27 ` Vladislav Shpilevoy
2020-05-19 12:11 ` Alexander Turenko
2020-05-19 20:48 ` Vladislav Shpilevoy
2020-05-19 13:23 ` Nikita Pettik
2020-05-18 15:25 ` [Tarantool-patches] [PATCH 0/5] mp_snprint() and mp_fprint() for decimal, uuid, error Serge Petrenko
2020-05-21 18:25 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512212724.GI2219@grain \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 4/5] error: provide MP_ERROR extension serializer' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox